Skip to content

Commit e075505

Browse files
committed
Handle @metadata.controller_dir properly
... and the other optional parameters as well. We also fix the other fetch of run.prefix which could be undefined.
1 parent 147f5b7 commit e075505

File tree

3 files changed

+19
-21
lines changed

3 files changed

+19
-21
lines changed

web-server/v0.4/src/models/dashboard.js

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -85,31 +85,28 @@ export default {
8585
);
8686
return;
8787
}
88-
let config =
89-
typeof result.fields['run.config'] != 'undefined' ? result.fields['run.config'][0] : null;
90-
let prefix =
91-
typeof result.fields['run.prefix'] != 'undefined' ? result.fields['run.prefix'][0] : null;
92-
let controller_dir =
93-
typeof result.fields['@metadata.controller_dir'] != 'undefined'
94-
? result.fields['@metadata.controller_dir'][0]
95-
: null;
96-
let satellite =
97-
typeof result.fields['@metadata.satellite'] != 'undefined'
98-
? result.fields['@metadata.satellite'][0]
99-
: null;
100-
results.push({
88+
let record = {
10189
key: name,
10290
startUnixTimestamp: Date.parse(start),
103-
['@metadata.controller_dir']: controller_dir,
104-
['@metadata.satellite']: satellite,
10591
['run.name']: name,
106-
['run.config']: config,
10792
['run.controller']: controller,
108-
['run.prefix']: prefix,
10993
['run.start']: start,
11094
['run.end']: end,
11195
['id']: id,
112-
});
96+
};
97+
if (typeof result.fields['run.config'] != 'undefined') {
98+
record['run.config'] = result.fields['run.config'][0];
99+
}
100+
if (typeof result.fields['run.prefix'] != 'undefined') {
101+
record['run.prefix'] = result.fields['run.prefix'][0];
102+
}
103+
if (typeof result.fields['@metadata.controller_dir'] != 'undefined') {
104+
record['@metadata.controller_dir'] = result.fields['@metadata.controller_dir'][0];
105+
}
106+
if (typeof result.fields['@metadata.satellite'] != 'undefined') {
107+
record['@metadata.satellite'] = result.fields['@metadata.satellite'][0];
108+
}
109+
results.push(record);
113110
});
114111

115112
yield put({

web-server/v0.4/src/models/search.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ export default {
5858
selectedFields.map(field => {
5959
parsedResult[field] = result._source[field.split('.')[0]][field.split('.')[1]];
6060
});
61-
parsedResult['run.prefix'] =
62-
result._source['run.prefix'.split('.')[0]]['run.prefix'.split('.')[1]];
61+
if (typeof result._source['run']['prefix'] != 'undefined') {
62+
parsedResult['run.prefix'] = result._source['run']['prefix'];
63+
}
6364
parsedResults.push(parsedResult);
6465
});
6566
searchResults['results'] = parsedResults;

web-server/v0.4/src/services/dashboard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export async function queryIterations(params) {
134134

135135
let iterationRequests = [];
136136
selectedResults.map(result => {
137-
const controller_dir = result['@metadata.controller_dir'];
137+
let controller_dir = result['@metadata.controller_dir'];
138138
if (controller_dir === undefined) {
139139
controller_dir = result['run.controller'];
140140
controller_dir = controller_dir.includes('.')

0 commit comments

Comments
 (0)