improvements

Author: dkorecko

PatchPanda.Web/Services/Interfaces/INotificationService.cs

@@ -24,9 +24,14 @@ List<AppVersion> newerVersions
     /// Sends a notification message via all initialized services.
     /// </summary>
     /// <param name="message">Message to send</param>
-    /// <param name="propagateExceptions">Whether any failures should throw</param>
+    /// <param name="propagateExceptions">Whether any failures should throw. If false, it will log failures instead of throwing</param>
+    /// <param name="noSuccessIsError">Whether it should throw error when sending notification was not successful</param>
     /// <returns>Boolean determining if any notifications were successful</returns>
-    Task<bool> TrySendNotification(string message, bool propagateExceptions = false);
+    Task<bool> TrySendNotification(
+        string message,
+        bool propagateExceptions = false,
+        bool noSuccessIsError = true
+    );
 
     /// <summary>
     /// Sends a notification message via all initialized services, but throws if none succeed and if any of them fail.

PatchPanda.Web/Services/NotificationService.cs

@@ -44,7 +44,7 @@ public async Task SendAutoUpdateResult(
         var result = await TrySendNotification(message);
 
         if (!result)
-            logger.LogError(
+            logger.LogWarning(
                 "Failed to send auto-update notification for container {ContainerName}",
                 container.Name
             );
@@ -61,7 +61,11 @@ List<AppVersion> newerVersions
         return await TrySendNotification(message);
     }
 
-    public async Task<bool> TrySendNotification(string message, bool propagateExceptions = false)
+    public async Task<bool> TrySendNotification(
+        string message,
+        bool propagateExceptions = false,
+        bool noSuccessIsError = false
+    )
     {
         var success = 0;
         if (discordService.IsInitialized)
@@ -97,21 +101,18 @@ public async Task<bool> TrySendNotification(string message, bool propagateExcept
         if (success != 0)
             return true;
 
-        if (!AnyInitialized)
-            logger.LogWarning("No notification services are initialized. Message was not sent.");
-        else
-            logger.LogError("The notification could not be sent successfully.");
+        var errorMessage = !AnyInitialized
+            ? "No notification services are initialized. Message was not sent."
+            : "The notification could not be sent successfully.";
 
-        return false;
-    }
+        if (noSuccessIsError)
+            throw new(errorMessage);
 
-    public async Task SendNotification(string message)
-    {
-        var result = await TrySendNotification(message, true);
+        logger.LogWarning(errorMessage);
 
-        if (!result)
-            throw new Exception(
-                "No notification services have been initialized. Check logs for details."
-            );
+        return false;
     }
+
+    public async Task SendNotification(string message) =>
+        await TrySendNotification(message, true, true);
 }