From a6096dc7e15e97f55a60d53b0cccacaf72f766c2 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 12 Jun 2026 11:12:49 +0200 Subject: [PATCH] deb: remove --dpkg-shlibdeps-params=--ignore-missing-info override This override was originally added in [moby@bb66d71] in 2016, which updated the build scripts for building the new `containerd`, `containerd-shim`, `ctr`, and `runc` binaries. Unfortunately, the pull request did not call-out the reason for adding this specific override, but there was a discussion about some distros not having the required GCC version to compile seccomp; > This is currently failing on oracle linux-6 because it can't compile runc > (...) It looks like it is related to this bug: seccomp/libseccomp-golang#2 > which states that the gcc version is too old. Currently, the gcc version > that comes with oracle linux 6 is gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16) > > ... > > It looks like ubuntu precise has the same gcc issue, it isn't new enough. > Looks like the newest version that is apt is 4.6.3, and I need at least > 4.6.4. The [dpkg-shlibdeps(1)] manpage explicitly calls this option out as discouraged: --ignore-missing-info Do not fail if dependency information can't be found for a shared library (since dpkg 1.14.8). Usage of this option is discouraged, all libraries should provide dependency information (either with shlibs files, or with symbols files) even if they are not yet used by other packages. Let's remove this option, as it's discouraged, may be hiding real problems (missing dependencies that would otherwise fail the build), and very likely was never needed for most CLI binaries, and the containerd binaries are no longer built as part of this package (and do not have this option set). [moby@bb66d71]: https://github.com/moby/moby/commit/bb66d7144f7d0a617f5985486ae36bbbaa5461ba [dpkg-shlibdeps(1)]: https://manpages.debian.org/trixie/dpkg-dev/dpkg-shlibdeps.1.en.html#ignore Signed-off-by: Sebastiaan van Stijn --- deb/common/rules | 3 --- 1 file changed, 3 deletions(-) diff --git a/deb/common/rules b/deb/common/rules index 765794da7c..cc824f94ae 100755 --- a/deb/common/rules +++ b/deb/common/rules @@ -133,9 +133,6 @@ override_dh_installsystemd: # use "docker" as our service name, not "docker-ce" dh_installsystemd --name=docker -override_dh_shlibdeps: - dh_shlibdeps --dpkg-shlibdeps-params=--ignore-missing-info - override_dh_install: dh_install # TODO Can we do this from within our container?