Update tests

Author: VincentLanglet

tests/Platforms/AbstractMySQLPlatformTestCase.php

@@ -20,6 +20,7 @@
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\TransactionIsolationLevel;
 use Doctrine\DBAL\Types\Types;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 use function array_shift;
 
@@ -622,6 +623,13 @@ protected function createComparator(): Comparator
         );
     }
 
+    /** @param array<string> $values */
+    #[DataProvider('getEnumDeclarationExceptionWithLengthSQLProvider')]
+    public function testGetEnumDeclarationExceptionWithLengthSQL(array $values, int $length): void
+    {
+        self::markTestSkipped('There is no exception thrown on MySQL.');
+    }
+
     /** @return array<string, array{array<string>, string}> */
     public static function getEnumDeclarationSQLProvider(): array
     {
@@ -631,7 +639,7 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string|null}> */
+    /** @return array<string, array{array<string>, int, string}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [

tests/Platforms/AbstractPlatformTestCase.php

@@ -1220,32 +1220,43 @@ public static function getEnumDeclarationSQLProvider(): array
 
     /** @param array<string> $values */
     #[DataProvider('getEnumDeclarationWithLengthSQLProvider')]
-    public function testGetEnumDeclarationWithLengthSQL(array $values, int $length, ?string $expectedSQL = null): void
+    public function testGetEnumDeclarationWithLengthSQL(array $values, int $length, string $expectedSQL): void
     {
-        if ($expectedSQL === null) {
-            $this->expectException(InvalidArgumentException::class);
-        }
-
         $result = $this->platform->getEnumDeclarationSQL([
             'values' => $values,
             'length' => $length,
         ]);
 
-        if ($expectedSQL === null) {
-            return;
-        }
-
         self::assertSame($expectedSQL, $result);
     }
 
-    /** @return array<string, array{array<string>, int, string|null}> */
+    /** @param array<string> $values */
+    #[DataProvider('getEnumDeclarationExceptionWithLengthSQLProvider')]
+    public function testGetEnumDeclarationExceptionWithLengthSQL(array $values, int $length): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+
+        $this->platform->getEnumDeclarationSQL([
+            'values' => $values,
+            'length' => $length,
+        ]);
+    }
+
+    /** @return array<string, array{array<string>, int, string}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'VARCHAR(42)'],
-            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'VARCHAR(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
+        ];
+    }
+
+    /** @return array<string, array{array<string>, int}> */
+    public static function getEnumDeclarationExceptionWithLengthSQLProvider(): array
+    {
+        return [
+            'single value and lower length' => [['foo'], 1],
+            'multiple values and lower length' => [['foo', 'bar1'], 2],
         ];
     }
 

tests/Platforms/OraclePlatformTest.php

@@ -652,14 +652,12 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string|null}> */
+    /** @return array<string, array{array<string>, int, string}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'VARCHAR2(42)'],
-            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'VARCHAR2(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
         ];
     }
 }

tests/Platforms/SQLServerPlatformTest.php

@@ -1226,14 +1226,12 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string|null}> */
+    /** @return array<string, array{array<string>, int, string}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'NVARCHAR(42)'],
-            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'NVARCHAR(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
         ];
     }
 }