Removing the bc break

Author: mamazu

src/Schema/AbstractSchemaManager.php

@@ -817,7 +817,7 @@ protected function _getPortableTableColumnList(string $table, string $database,
             try {
                 $column = $this->_getPortableTableColumnDefinition($row);
             } catch (UnknownColumnType $unknownTypeException) {
-                throw UnknownColumnType::withContext($unknownTypeException->getType(), sprintf('table %s', $table));
+                throw UnknownColumnType::newWithContext($unknownTypeException->getRequestedType(), $table);
             }
 
             $name        = strtolower($column->getQuotedName($this->platform));

src/Types/Exception/UnknownColumnType.php

@@ -5,45 +5,52 @@
 namespace Doctrine\DBAL\Types\Exception;
 
 use Exception;
-use Throwable;
 
 use function sprintf;
 
 final class UnknownColumnType extends Exception implements TypesException
 {
-    private function __construct(
-        private string $requestedType,
-        ?string $context,
-        int $code = 0,
-        ?Throwable $throwable = null,
-    ) {
-        $message = sprintf(
-            'Unknown column type "%s" requested%s. Any Doctrine type that you use has '
+    private string $requestedType;
+
+    public function getRequestedType(): string
+    {
+        return $this->requestedType;
+    }
+
+    public static function new(string $name): self
+    {
+        $object = new self(sprintf(
+            'Unknown column type "%s" requested. Any Doctrine type that you use has '
                     . 'to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the '
                     . 'known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database '
                     . 'introspection then you might have forgotten to register all database types for a Doctrine Type. '
                     . 'Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement '
                     . 'Type#getMappedDatabaseTypes(). If the type name is empty you might '
                     . 'have a problem with the cache or forgot some mapping information.',
-            $this->requestedType,
-            $context !== null ? ' for ' . $context : '',
-        );
+            $name,
+        ));
 
-        parent::__construct($message, $code, $throwable);
-    }
+        $object->requestedType = $name;
 
-    public function getType(): string
-    {
-        return $this->requestedType;
+        return $object;
     }
 
-    public static function new(string $name): self
+    public static function newWithContext(string $name, string $tableName): self
     {
-        return new self($name, null);
-    }
+        $object = new self(sprintf(
+            'Unknown column type "%s" requested for table "%s". Any Doctrine type that you use has '
+                    . 'to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the '
+                    . 'known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database '
+                    . 'introspection then you might have forgotten to register all database types for a Doctrine Type. '
+                    . 'Use AbstractPlatform#registerDoctrineTypeMapping() or have your custom types implement '
+                    . 'Type#getMappedDatabaseTypes(). If the type name is empty you might '
+                    . 'have a problem with the cache or forgot some mapping information.',
+            $name,
+            $tableName,
+        ));
 
-    public static function withContext(string $name, string $context): self
-    {
-        return new self($name, $context);
+        $object->requestedType = $name;
+
+        return $object;
     }
 }

tests/Types/Exception/UnknownColumnTypeTest.php

@@ -13,7 +13,7 @@ public function testNew(): void
     {
         $exception = UnknownColumnType::new('custom_type');
 
-        self::assertSame('custom_type', $exception->getType());
+        self::assertSame('custom_type', $exception->getRequestedType());
         self::assertStringContainsString(
             'Unknown column type "custom_type" requested.',
             $exception->getMessage(),
@@ -22,9 +22,9 @@ public function testNew(): void
 
     public function testWithContext(): void
     {
-        $exception = UnknownColumnType::withContext('custom_type', 'table "some_table"');
+        $exception = UnknownColumnType::newWithContext('custom_type', 'some_table');
 
-        self::assertSame('custom_type', $exception->getType());
+        self::assertSame('custom_type', $exception->getRequestedType());
         self::assertStringContainsString(
             'Unknown column type "custom_type" requested for table "some_table".',
             $exception->getMessage(),