Throws exception

Author: VincentLanglet

src/Platforms/AbstractPlatform.php

@@ -244,12 +244,20 @@ public function getEnumDeclarationSQL(array $column): string
             throw ColumnValuesRequired::new($this, 'ENUM');
         }
 
-        $configuredLength = $column['length'] ?? 0;
-        $neededLength     = count($column['values']) > 1
+        $length = count($column['values']) > 1
             ? max(...array_map(mb_strlen(...), $column['values']))
             : mb_strlen($column['values'][key($column['values'])]);
 
-        $length = max($configuredLength, $neededLength);
+        if (isset($column['length'])) {
+            if ($length > $column['length']) {
+                throw new InvalidArgumentException(sprintf(
+                    'Specified column length (%d) is less than the maximum length of provided values (%d).',
+                    $column['length'],
+                    $length,
+                ));
+            }
+            $length = $column['length'];
+        }
 
         return $this->getStringTypeDeclarationSQL(['length' => $length]);
     }

tests/Platforms/AbstractMySQLPlatformTestCase.php

@@ -631,7 +631,7 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string}> */
+    /** @return array<string, array{array<string>, int, string|null}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [

tests/Platforms/AbstractPlatformTestCase.php

@@ -1220,22 +1220,30 @@ public static function getEnumDeclarationSQLProvider(): array
 
     /** @param array<string> $values */
     #[DataProvider('getEnumDeclarationWithLengthSQLProvider')]
-    public function testGetEnumDeclarationWithLengthSQL(array $values, int $length, string $expectedSQL): void
+    public function testGetEnumDeclarationWithLengthSQL(array $values, int $length, ?string $expectedSQL = null): void
     {
-        self::assertSame($expectedSQL, $this->platform->getEnumDeclarationSQL([
+        if ($expectedSQL === null) {
+            $this->expectException(InvalidArgumentException::class);
+        }
+
+        $result = $this->platform->getEnumDeclarationSQL([
             'values' => $values,
             'length' => $length,
-        ]));
+        ]);
+
+        if ($expectedSQL !== null) {
+            self::assertSame($expectedSQL, $result);
+        }
     }
 
-    /** @return array<string, array{array<string>, int, string}> */
+    /** @return array<string, array{array<string>, int, string|null}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'VARCHAR(42)'],
-            'single value and lower length' => [['foo'], 1, 'VARCHAR(3)'],
+            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'VARCHAR(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, 'VARCHAR(4)'],
+            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
         ];
     }
 

tests/Platforms/OraclePlatformTest.php

@@ -652,14 +652,14 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string}> */
+    /** @return array<string, array{array<string>, int, string|null}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'VARCHAR2(42)'],
-            'single value and lower length' => [['foo'], 1, 'VARCHAR2(3)'],
+            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'VARCHAR2(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, 'VARCHAR2(4)'],
+            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
         ];
     }
 }

tests/Platforms/SQLServerPlatformTest.php

@@ -1226,14 +1226,14 @@ public static function getEnumDeclarationSQLProvider(): array
         ];
     }
 
-    /** @return array<string, array{array<string>, int, string}> */
+    /** @return array<string, array{array<string>, int, string|null}> */
     public static function getEnumDeclarationWithLengthSQLProvider(): array
     {
         return [
             'single value and bigger length' => [['foo'], 42, 'NVARCHAR(42)'],
-            'single value and lower length' => [['foo'], 1, 'NVARCHAR(3)'],
+            'single value and lower length' => [['foo'], 1, null],
             'multiple values and bigger length' => [['foo', 'bar1'], 42, 'NVARCHAR(42)'],
-            'multiple values and lower length' => [['foo', 'bar1'], 2, 'NVARCHAR(4)'],
+            'multiple values and lower length' => [['foo', 'bar1'], 2, null],
         ];
     }
 }