Remove Doctrine\DBAL\Types\Type::getDefaultLength()

Author: Majkl578

UPGRADE.md

@@ -1,5 +1,9 @@
 # Upgrade to 3.0
 
+## BC BREAK: `Doctrine\DBAL\Types\Type::getDefaultLength()` removed
+
+The `Doctrine\DBAL\Types\Type::getDefaultLength()` method has been removed as it served no purpose.
+
 ## BC BREAK: `Doctrine\DBAL\Types\Type::__toString()` removed
 
 Relying on string representation was discouraged and has been removed.

lib/Doctrine/DBAL/Types/StringType.php

@@ -17,14 +17,6 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
         return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function getDefaultLength(AbstractPlatform $platform)
-    {
-        return $platform->getVarcharDefaultLength();
-    }
-
     /**
      * {@inheritdoc}
      */

lib/Doctrine/DBAL/Types/Type.php

@@ -114,18 +114,6 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
         return $value;
     }
 
-    /**
-     * Gets the default length of this type.
-     *
-     * @deprecated Rely on information provided by the platform instead.
-     *
-     * @return int|null
-     */
-    public function getDefaultLength(AbstractPlatform $platform)
-    {
-        return null;
-    }
-
     /**
      * Gets the SQL declaration snippet for a field of this type.
      *

tests/Doctrine/Tests/DBAL/Types/StringTest.php

@@ -25,11 +25,6 @@ public function testReturnsSqlDeclarationFromPlatformVarchar()
         self::assertEquals('DUMMYVARCHAR()', $this->type->getSqlDeclaration([], $this->platform));
     }
 
-    public function testReturnsDefaultLengthFromPlatformVarchar()
-    {
-        self::assertEquals(255, $this->type->getDefaultLength($this->platform));
-    }
-
     public function testConvertToPHPValue()
     {
         self::assertInternalType('string', $this->type->convertToPHPValue('foo', $this->platform));