PersistentCollection doesn't have the matching method

[dorongutman]

Both https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/PersistentCollection.php#L861 and https://github.com/doctrine/collections/blob/master/lib/Doctrine/Common/Collections/ArrayCollection.php#L358 (which is the type one needs to use on a ReferenceMany field) have a "matching" method for searching (via a Criteria) a set of items in the collections.

However - https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/PersistentCollection.php (which is what returned on a ReferenceMany field) doesn't have that method.

How can I search in the ReferenceMany field ?

[jmikola]

This feature isn't yet implemented. Quoting the 1.0 changelog:

The base DocumentRepository class now implements the Selectable interface from the Criteria API in Doctrine Collections 1.1. This brings some consistency with ORM; however, ODM's PersistentCollection class does not yet support Selectable. This functionality was introduced in #699.

[youuri]

Hi guys, any update on this issue?

[alcaeus]

None besides what's written above. It's in the 1.x milestone, meaning we are willing to add it to one of the next 1.x releases, but nothing more than that. You could always help get things started by creating a pull request!

[redthor]

I thought the custom collections feature made this less important?

…

On 7 Dec 2016 5:23 pm, "Andreas" ***@***.***> wrote: None besides what's written above. It's in the 1.x milestone, meaning we are willing to add it to one of the next 1.x releases, but nothing more than that. You could always help get things started by creating a pull request! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#929 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAu3mPs1jYpa0mXYL-04fi0AZZzgHvd_ks5rFlDRgaJpZM4Cahuy> .

[svscorp]

+1 for having this feature

I checked the ArrayCollection::matching() implementation, it can be implemented in a similar way in PersistentCollection I believe. Ideally using PersistentCollection's methods instead of array_*. But then few more methods needs to be implemented, i.e. PersistentCollection::reverse.

What do you think?

@alcaeus

[alcaeus]

@svscorp I haven't taken a look in a while. Since you have an idea about how to implement it, could you create a pull request?