Skip to content

Commit 4c9536e

Browse files
committed
Gate WPF scenarios to internal runs due to CloseFailed on CI VMs
WPF Template and WPF SFC fail with CloseFailed on generic Helix CI VMs because CloseMainWindow() doesn't work in headless environments. This is the same issue that caused WinForms scenarios to be gated. Gate both WPF scenarios behind SYSTEM_TEAMPROJECT=internal, with IncludeVMFlakyScenarios override.
1 parent 25d9878 commit 4c9536e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

eng/performance/scenarios.proj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,15 @@
4343
<ScenarioDirectoryName>windowsformslarge</ScenarioDirectoryName>
4444
<PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
4545
</UIScenario>
46-
<UIScenario Include="WPF Template" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT'">
46+
<!-- WPF Template: limited to internal runs due to CloseFailed on generic CI VMs (same issue as WinForms).
47+
Override with /p:IncludeVMFlakyScenarios=true to include on other builds. -->
48+
<UIScenario Include="WPF Template" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT' AND ( '$(SYSTEM_TEAMPROJECT)' == 'internal' OR '$(IncludeVMFlakyScenarios)' == 'true' )">
4749
<ScenarioDirectoryName>wpf</ScenarioDirectoryName>
4850
<PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
4951
</UIScenario>
50-
<UIScenario Include="WPF SFC" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT'">
52+
<!-- WPF SFC: gated for consistency with WPF Template.
53+
Override with /p:IncludeVMFlakyScenarios=true to include on other builds. -->
54+
<UIScenario Include="WPF SFC" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT' AND ( '$(SYSTEM_TEAMPROJECT)' == 'internal' OR '$(IncludeVMFlakyScenarios)' == 'true' )">
5155
<ScenarioDirectoryName>wpfsfc</ScenarioDirectoryName>
5256
<PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
5357
</UIScenario>

0 commit comments

Comments
 (0)