Fix issue with when a CR/LF split occurs at a SubText's underlying span start #80911
+55
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an start I hit an exception in the SourceText system when inserting a copilot edit for C# content in a razor file when the file uses newlines only. This ended up causing a CR/NL split in the subtext class, which had some bogus logic for when that happened. Added a very simple unit test that demonstrated previous failure.
ToddGrun
changed the title
|
@dotnet/roslyn-compiler -- ptal |
CyrusNajmabadi
approved these changes
Oct 28, 2025
2) Fix bug that found where a TextLine was being created with a start position that was beyond the subtext's length.
|
@dotnet/roslyn-compiler -- ptal. Thanks! |
333fred
approved these changes
Oct 29, 2025
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit an exception in the SourceText system when inserting a copilot edit for C# content in a razor file when the file uses newlines only. This ended up causing a CR/LF split in the subtext class, which had some bogus logic for when that happened.
Added a very simple unit test that demonstrated previous failure.