Skip to content

Commit 807e605

Browse files
Copilotmattleibow
andcommitted
Address feedback: Remove conditional compilation blocks, delete documentation and samples
Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
1 parent dc9d9eb commit 807e605

File tree

8 files changed

+1
-243
lines changed

8 files changed

+1
-243
lines changed

README.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -148,15 +148,6 @@ Other parameters can be overrided as well if needed.
148148

149149
Currently we support **xunit v2**, **xunit v3**, and **NUnit** test assemblies but the `Microsoft.DotNet.XHarness.Tests.Runners` supports implementation of custom runner too.
150150

151-
### xunit Version Support
152-
153-
XHarness supports both xunit v2 and the newer xunit v3:
154-
155-
- **xunit v2**: `Microsoft.DotNet.XHarness.TestRunners.Xunit` (stable, recommended for production)
156-
- **xunit v3**: `Microsoft.DotNet.XHarness.TestRunners.Xunit.v3` (stable, latest xunit architecture)
157-
158-
For guidance on choosing between versions, see the [xunit Version Selection Guide](docs/XunitVersionSelection.md).
159-
160151
## Development instructions
161152
When working on XHarness, there are couple of neat hacks that can improve the inner loop.
162153
The repository can either be built using regular .NET, assuming you have new enough version:

docs/XunitVersionSelection.md

Lines changed: 0 additions & 109 deletions
This file was deleted.

samples/xunit-v3-sample/Program.cs

Lines changed: 0 additions & 57 deletions
This file was deleted.

samples/xunit-v3-sample/README.md

Lines changed: 0 additions & 40 deletions
This file was deleted.

samples/xunit-v3-sample/xunit-v3-sample.csproj

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/Microsoft.DotNet.XHarness.TestRunners.Xunit/AndroidApplicationEntryPoint.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@ public abstract class AndroidApplicationEntryPoint : AndroidApplicationEntryPoin
1313

1414
protected override TestRunner GetTestRunner(LogWriter logWriter)
1515
{
16-
#if USE_XUNIT_V3
17-
var runner = new XUnitTestRunner(logWriter);
18-
#else
1916
var runner = new XUnitTestRunner(logWriter) { MaxParallelThreads = MaxParallelThreads };
20-
#endif
2117
ConfigureRunnerFilters(runner, ApplicationOptions.Current);
2218
return runner;
2319
}

src/Microsoft.DotNet.XHarness.TestRunners.Xunit/WasmApplicationEntryPoint.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ public abstract class WasmApplicationEntryPoint : WasmApplicationEntryPointBase
2828
protected override TestRunner GetTestRunner(LogWriter logWriter)
2929
{
3030
#if USE_XUNIT_V3
31-
var runner = new XUnitTestRunner(logWriter);
32-
ConfigureRunnerFilters(runner, ApplicationOptions.Current);
33-
return runner;
31+
throw new NotSupportedException("xunit v3 is not supported for WASM applications.");
3432
#else
3533
XunitTestRunnerBase runner = IsThreadless
3634
? new ThreadlessXunitTestRunner(logWriter)

src/Microsoft.DotNet.XHarness.TestRunners.Xunit/iOSApplicationEntryPoint.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ public abstract class iOSApplicationEntryPoint : iOSApplicationEntryPointBase
1111
{
1212
protected override TestRunner GetTestRunner(LogWriter logWriter)
1313
{
14-
#if USE_XUNIT_V3
15-
var runner = new XUnitTestRunner(logWriter);
16-
#else
1714
var runner = new XUnitTestRunner(logWriter) { MaxParallelThreads = MaxParallelThreads };
18-
#endif
1915
ConfigureRunnerFilters(runner, ApplicationOptions.Current);
2016
return runner;
2117
}

0 commit comments

Comments
 (0)