Skip to content

Published package contains more than it should? #293

@9swampy

Description

@9swampy

I've another PR to add data-action support that I've scope published pending the PR review. While working out how to publish an npm package I noted;

  1. More than I think you intend is being included in the publish package? Look at the (beta)Code tab on the package page.
  2. There's no index.d.ts.

On my repo you'll find a ScopedPackage branch that adds a GitHub action publish workflow that addresses each of the above.

Tbh I'm not certain if best practice is to include the type file or to prefer @types dev dependency, but for the scoped package the existing @types package doesn't work, so I had to include it, happy to remove; but take a look and if there's a PR you'd consider merging let me know?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions