Skip to content

Commit 6cc15fb

Browse files
committed
Fix lints
1 parent 74ea7db commit 6cc15fb

File tree

2 files changed

+16
-25
lines changed

2 files changed

+16
-25
lines changed

plugin/release.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (rc *releaseClient) buildRelease() (*gitea.Release, error) {
4040
release, err = rc.newRelease()
4141

4242
if err != nil {
43-
return nil, fmt.Errorf("Failed to retrieve or create a release: %s", err)
43+
return nil, fmt.Errorf("failed to retrieve or create a release: %s", err)
4444
}
4545

4646
return release, nil
@@ -54,11 +54,11 @@ func (rc *releaseClient) getRelease() (*gitea.Release, error) {
5454

5555
for _, release := range releases {
5656
if release.TagName == rc.Tag {
57-
fmt.Printf("Successfully retrieved %s release\n", rc.Tag)
57+
fmt.Printf("successfully retrieved %s release\n", rc.Tag)
5858
return release, nil
5959
}
6060
}
61-
return nil, fmt.Errorf("Release %s not found", rc.Tag)
61+
return nil, fmt.Errorf("release %s not found", rc.Tag)
6262
}
6363

6464
func (rc *releaseClient) newRelease() (*gitea.Release, error) {
@@ -72,18 +72,18 @@ func (rc *releaseClient) newRelease() (*gitea.Release, error) {
7272

7373
release, _, err := rc.Client.CreateRelease(rc.Owner, rc.Repo, r)
7474
if err != nil {
75-
return nil, fmt.Errorf("Failed to create release: %s", err)
75+
return nil, fmt.Errorf("failed to create release: %s", err)
7676
}
7777

78-
fmt.Printf("Successfully created %s release\n", rc.Tag)
78+
fmt.Printf("successfully created %s release\n", rc.Tag)
7979
return release, nil
8080
}
8181

8282
func (rc *releaseClient) uploadFiles(releaseID int64, files []string) error {
8383
attachments, _, err := rc.Client.ListReleaseAttachments(rc.Owner, rc.Repo, releaseID, gitea.ListReleaseAttachmentsOptions{})
8484

8585
if err != nil {
86-
return fmt.Errorf("Failed to fetch existing assets: %s", err)
86+
return fmt.Errorf("failed to fetch existing assets: %s", err)
8787
}
8888

8989
var uploadFiles []string
@@ -96,12 +96,12 @@ files:
9696
case "overwrite":
9797
// do nothing
9898
case "fail":
99-
return fmt.Errorf("Asset file %s already exists", path.Base(file))
99+
return fmt.Errorf("asset file %s already exists", path.Base(file))
100100
case "skip":
101-
fmt.Printf("Skipping pre-existing %s artifact\n", attachment.Name)
101+
fmt.Printf("skipping pre-existing %s artifact\n", attachment.Name)
102102
continue files
103103
default:
104-
return fmt.Errorf("Internal error, unkown file_exist value %s", rc.FileExists)
104+
return fmt.Errorf("internal error, unkown file_exist value %s", rc.FileExists)
105105
}
106106
}
107107
}
@@ -113,24 +113,24 @@ files:
113113
handle, err := os.Open(file)
114114

115115
if err != nil {
116-
return fmt.Errorf("Failed to read %s artifact: %s", file, err)
116+
return fmt.Errorf("failed to read %s artifact: %s", file, err)
117117
}
118118

119119
for _, attachment := range attachments {
120120
if attachment.Name == path.Base(file) {
121121
if _, err := rc.Client.DeleteReleaseAttachment(rc.Owner, rc.Repo, releaseID, attachment.ID); err != nil {
122-
return fmt.Errorf("Failed to delete %s artifact: %s", file, err)
122+
return fmt.Errorf("failed to delete %s artifact: %s", file, err)
123123
}
124124

125-
fmt.Printf("Successfully deleted old %s artifact\n", attachment.Name)
125+
fmt.Printf("successfully deleted old %s artifact\n", attachment.Name)
126126
}
127127
}
128128

129129
if _, _, err = rc.Client.CreateReleaseAttachment(rc.Owner, rc.Repo, releaseID, handle, path.Base(file)); err != nil {
130-
return fmt.Errorf("Failed to upload %s artifact: %s", file, err)
130+
return fmt.Errorf("failed to upload %s artifact: %s", file, err)
131131
}
132132

133-
fmt.Printf("Successfully uploaded %s artifact\n", file)
133+
fmt.Printf("successfully uploaded %s artifact\n", file)
134134
}
135135

136136
return nil

plugin/utils.go

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,6 @@ var (
2929
}
3030
)
3131

32-
func execute(cmd *exec.Cmd) error {
33-
fmt.Println("+", strings.Join(cmd.Args, " "))
34-
35-
cmd.Stderr = os.Stderr
36-
cmd.Stdin = os.Stdin
37-
38-
return cmd.Run()
39-
}
40-
4132
func readStringOrFile(input string) (string, error) {
4233
// Check if input is a file path
4334
if _, err := os.Stat(input); err != nil && os.IsNotExist(err) {
@@ -75,7 +66,7 @@ func checksum(r io.Reader, method string) (string, error) {
7566
return strconv.FormatUint(uint64(crc32.ChecksumIEEE(b)), 10), nil
7667
}
7768

78-
return "", fmt.Errorf("Hashing method %s is not supported", method)
69+
return "", fmt.Errorf("hashing method %s is not supported", method)
7970
}
8071

8172
func writeChecksums(files, methods []string) ([]string, error) {
@@ -86,7 +77,7 @@ func writeChecksums(files, methods []string) ([]string, error) {
8677
handle, err := os.Open(file)
8778

8879
if err != nil {
89-
return nil, fmt.Errorf("Failed to read %s artifact: %s", file, err)
80+
return nil, fmt.Errorf("failed to read %s artifact: %s", file, err)
9081
}
9182

9283
hash, err := checksum(handle, method)

0 commit comments

Comments
 (0)