Skip to content

Commit f584c84

Browse files
fix: Cross filters initial scope (#25074)
1 parent 8d33400 commit f584c84

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

superset-frontend/src/dashboard/constants.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DatasourceType } from '@superset-ui/core';
1+
import { DatasourceType, NativeFilterScope } from '@superset-ui/core';
22
import { Datasource } from 'src/dashboard/types';
33
import { DASHBOARD_ROOT_ID } from './util/constants';
44
/**
@@ -44,7 +44,7 @@ export const FILTER_BAR_TABS_HEIGHT = 46;
4444
export const BUILDER_SIDEPANEL_WIDTH = 374;
4545
export const OVERWRITE_INSPECT_FIELDS = ['css', 'json_metadata.filter_scopes'];
4646

47-
export const DEFAULT_CROSS_FILTER_SCOPING = {
47+
export const DEFAULT_CROSS_FILTER_SCOPING: NativeFilterScope = {
4848
rootPath: [DASHBOARD_ROOT_ID],
4949
excluded: [],
5050
};

superset-frontend/src/dashboard/util/crossFilters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const getCrossFiltersConfiguration = (
5252
return undefined;
5353
}
5454

55-
const globalChartConfiguration = metadata.global_chart_configuration
55+
const globalChartConfiguration = metadata.global_chart_configuration?.scope
5656
? {
5757
scope: metadata.global_chart_configuration.scope,
5858
chartsInScope: getChartIdsInFilterScope(

0 commit comments

Comments
 (0)