Summary
packages/contracts/*/test_snapshots/tests/*.1.json are auto-generated diagnostic captures written by soroban-sdk testutils after every cargo test run. Nothing in the test suite asserts against them, and they churn on nearly every contract PR, plus generate persistent false "modified" status on Windows checkouts due to line-ending normalization.
Motivation
These files add review noise (large diffs with no behavioral meaning) and have already caused a real problem this project: contributors (including repo maintainers) blanket-discarding "modified" snapshot files without checking whether they reflected real behavior changes, which let genuinely stale snapshots merge undetected across multiple PRs.
Proposed Solution
Either (a) add test_snapshots/ to .gitignore since nothing reads them and they carry no CI signal, or (b) if they have diagnostic value worth keeping in version control, add a CI step that regenerates them and fails the build if they drift from what's committed, so staleness is caught automatically instead of relying on manual diff review.
Scope
| Field |
Value |
| Area |
Contracts, CI |
| Protocol affected |
Both |
| Network |
N/A |
| Breaking change? |
No |
Alternatives Considered
Keeping the current manual-review approach: already demonstrated to fail in practice.
Acceptance Criteria
Additional Context
Directly related to the stale-snapshot cleanup done in PR #369, which fixed 7 files that had drifted undetected since PRs #363 and #367.
Summary
packages/contracts/*/test_snapshots/tests/*.1.jsonare auto-generated diagnostic captures written bysoroban-sdktestutils after everycargo testrun. Nothing in the test suite asserts against them, and they churn on nearly every contract PR, plus generate persistent false "modified" status on Windows checkouts due to line-ending normalization.Motivation
These files add review noise (large diffs with no behavioral meaning) and have already caused a real problem this project: contributors (including repo maintainers) blanket-discarding "modified" snapshot files without checking whether they reflected real behavior changes, which let genuinely stale snapshots merge undetected across multiple PRs.
Proposed Solution
Either (a) add
test_snapshots/to.gitignoresince nothing reads them and they carry no CI signal, or (b) if they have diagnostic value worth keeping in version control, add a CI step that regenerates them and fails the build if they drift from what's committed, so staleness is caught automatically instead of relying on manual diff review.Scope
Alternatives Considered
Keeping the current manual-review approach: already demonstrated to fail in practice.
Acceptance Criteria
cargo testruncargo testand CI both passAdditional Context
Directly related to the stale-snapshot cleanup done in PR #369, which fixed 7 files that had drifted undetected since PRs #363 and #367.