|
2 | 2 | Thanks for submitting a Pull Request (PR) to this project. |
3 | 3 | Your contribution to this project is greatly appreciated! |
4 | 4 |
|
5 | | - Please make sure you have read the [Contribution Guidelines](https://github.com/Microsoft/SChannelDsc/wiki/Contributing%20to%20SChannelDsc). |
6 | | -
|
7 | 5 | Please prefix the PR title with the resource name, |
8 | 6 | e.g. 'ResourceName: My short description'. |
9 | 7 | If this is a breaking change, then also prefix the PR title |
|
16 | 14 | #### Pull Request (PR) description |
17 | 15 | <!-- |
18 | 16 | Replace this comment block with a description of your PR. |
| 17 | + Also, make sure you have updated the CHANGELOG.md, see the |
| 18 | + task list below. An entry in the CHANGELOG.md is mandatory |
| 19 | + for all PRs. |
19 | 20 | --> |
20 | 21 |
|
21 | 22 | #### This Pull Request (PR) fixes the following issues |
22 | 23 | <!-- |
23 | 24 | If this PR does not fix an open issue, replace this comment block with None. |
24 | 25 | If this PR resolves one or more open issues, replace this comment block with |
25 | | - a list the issues using a GitHub closing keyword, e.g.: |
26 | | - - Fixes #123 |
27 | | - - Fixes #124 |
| 26 | + a list of the issues using a GitHub closing keyword, e.g.: |
| 27 | +
|
| 28 | +- Fixes #123 |
| 29 | +- Fixes #124 |
28 | 30 | --> |
29 | 31 |
|
30 | 32 | #### Task list |
|
36 | 38 | Change to [x] for each task in the task list that applies to your PR. |
37 | 39 | For those task that don't apply to you PR, leave those as is. |
38 | 40 | --> |
39 | | -- [ ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. |
40 | | - Entry should say what was changed, and how that affects users (if applicable). |
41 | | -- [ ] Resource documentation added/updated in README.md in the resource folder. |
42 | | -- [ ] Resource parameter descriptions added/updated in schema.mof |
| 41 | +- [ ] Added an entry to the change log under the Unreleased section of the |
| 42 | + file CHANGELOG.md. Entry should say what was changed and how that |
| 43 | + affects users (if applicable), and reference the issue being resolved |
| 44 | + (if applicable). |
| 45 | +- [ ] Resource documentation added/updated in README.md. |
| 46 | +- [ ] Resource parameter descriptions added/updated in README.md, schema.mof |
43 | 47 | and comment-based help. |
44 | 48 | - [ ] Comment-based help added/updated. |
45 | 49 | - [ ] Localization strings added/updated in all localization files as appropriate. |
46 | 50 | - [ ] Examples appropriately added/updated. |
47 | | -- [ ] Unit tests added/updated. See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). |
48 | | -- [ ] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). |
49 | | -- [ ] New/changed code adheres to [DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md). |
| 51 | +- [ ] Unit tests added/updated. See [DSC Community Testing Guidelines](https://dsccommunity.org/guidelines/testing-guidelines). |
| 52 | +- [ ] Integration tests added/updated (where possible). See [DSC Community Testing Guidelines](https://dsccommunity.org/guidelines/testing-guidelines). |
| 53 | +- [ ] New/changed code adheres to [DSC Community Style Guidelines](https://dsccommunity.org/styleguidelines). |
0 commit comments