Skip to content

Add DataChunkFromArrow #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wmTJc9IK0Q wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add DataChunkFromArrow #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions arrow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,3 +301,15 @@
defer r.mu.Unlock()
return r.err
}

// DataChunkFromArrow moves a record batch into an existing DuckDB DataChunk.
// Useful for implementing table functions that read from Arrow sources.
func (a *Arrow) DataChunkFromArrow(rec arrow.RecordBatch, chunk DataChunk) error {
s, ed := arrowmapping.SchemaFromArrow(a.conn.conn, rec.Schema())
if err := errorDataError(ed); err != nil {
return fmt.Errorf("failed to convert arrow schema to duckdb schema: %w", err)
}
defer arrowmapping.DestroyArrowConvertedSchema(&s)
ed = arrowmapping.DataChunkFromArrow(a.conn.conn, rec, s, chunk.chunk)

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (ubuntu-latest, 1.24) 

too many arguments in call to arrowmapping.DataChunkFromArrow

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (ubuntu-latest, 1.24) 

assignment mismatch: 1 variable but arrowmapping.DataChunkFromArrow returns 2 values

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (macos-latest, 1.24) 

too many arguments in call to arrowmapping.DataChunkFromArrow

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (macos-latest, 1.24) 

assignment mismatch: 1 variable but arrowmapping.DataChunkFromArrow returns 2 values

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (windows-latest, 1.24) 

too many arguments in call to arrowmapping.DataChunkFromArrow

Check failure on line 313 in arrow.go

View workflow job for this annotation

GitHub Actions / Test Arrow (windows-latest, 1.24) 

assignment mismatch: 1 variable but arrowmapping.DataChunkFromArrow returns 2 values
return errorDataError(ed)
}
92 changes: 92 additions & 0 deletions arrow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"context"
"database/sql"
"database/sql/driver"
"fmt"
"sync"
"testing"

Expand Down Expand Up @@ -315,3 +316,94 @@ func TestArrowClosedConn(t *testing.T) {
})
require.Error(t, err)
}

func TestArrowTableUDF(t *testing.T) {
db := openDbWrapper(t, ``)
defer closeDbWrapper(t, db)

conn := openConnWrapper(t, db, context.Background())
defer closeConnWrapper(t, conn)

c := newConnectorWrapper(t, ``, nil)
defer closeConnectorWrapper(t, c)

innerConn := openDriverConnWrapper(t, c)
defer closeDriverConnWrapper(t, &innerConn)

ar, err := NewArrowFromConn(innerConn)
require.NoError(t, err)

// Create an arrow array of type Float64 buffered in memory
schema := arrow.NewSchema([]arrow.Field{
{Name: "col0", Type: arrow.PrimitiveTypes.Float64},
}, nil)
alloc := memory.NewGoAllocator()
builder := array.NewFloat64Builder(alloc)
defer builder.Release()

// Add values > data chunk size to test multiple chunks
for range 10000 {
builder.Append(float64(0.5))
}

arr := builder.NewArray()
rb := array.NewRecordBatch(schema, []arrow.Array{arr}, int64(arr.Len()))
tbl := array.NewTableFromRecords(schema, []arrow.RecordBatch{rb})

RegisterTableUDF(conn, "get_arrow", ChunkTableFunction{
BindArguments: func(named map[string]any, args ...any) (ChunkTableSource, error) {
return &arrowTableUdf{tbl: tbl, ar: ar}, nil
},
})

res, err := db.QueryContext(context.Background(), `SELECT * FROM get_arrow()`)
require.NoError(t, err)
defer closeRowsWrapper(t, res)

var rowCount int
for res.Next() {
var val float64
require.NoError(t, res.Scan(&val))
require.Equal(t, 0.5, val)
rowCount++
}
require.Equal(t, 10000, rowCount)
}

// Define a table UDF
type arrowTableUdf struct {
ar *Arrow
tbl arrow.Table
rdr *array.TableReader
}

func (u *arrowTableUdf) Init() {
u.rdr = array.NewTableReader(u.tbl, int64(GetDataChunkCapacity()))
}

func (u *arrowTableUdf) ColumnInfos() []ColumnInfo {
t, _ := NewTypeInfo(TYPE_DOUBLE)
return []ColumnInfo{{
Name: "col0",
T: t,
}}
}

func (u *arrowTableUdf) Cardinality() *CardinalityInfo {
return &CardinalityInfo{
Cardinality: uint(u.tbl.NumRows()),
Exact: true,
}
}

func (u *arrowTableUdf) FillChunk(chunk DataChunk) error {
if u.rdr.Next() {
b := u.rdr.RecordBatch()
defer b.Release()
if err := u.ar.DataChunkFromArrow(b, chunk); err != nil {
return fmt.Errorf("failed to move arrow to data chunk: %w", err)
}
}

return nil
}
Loading