Merge pull request #362 from renatocron/feat/fix-memory-leak

Mytherin · web-flow · commit bf4cbd901336 · 2025-08-25T12:45:49.000+02:00
fix(postgres_text_reader.cpp): reset PGresult when result set is fully consumed to free resources immediately
diff --git a/src/postgres_text_reader.cpp b/src/postgres_text_reader.cpp
@@ -365,7 +365,14 @@ PostgresReadResult PostgresTextReader::Read(DataChunk &output) {
 		}
 	}
 	output.SetCardinality(scan_chunk.size());
-	return row_offset < result->Count() ? PostgresReadResult::HAVE_MORE_TUPLES : PostgresReadResult::FINISHED;
+
+	bool finished = row_offset >= result->Count();
+	if (finished) {
+		// The result set is fully consumed. Reset immediately to free the PGresult.
+		Reset();
+		return PostgresReadResult::FINISHED;
+	}
+	return PostgresReadResult::HAVE_MORE_TUPLES;
 }
 
 void PostgresTextReader::Reset() {

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,14 @@ PostgresReadResult PostgresTextReader::Read(DataChunk &output) {`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`	`output.SetCardinality(scan_chunk.size());`
`368`		`- return row_offset < result->Count() ? PostgresReadResult::HAVE_MORE_TUPLES : PostgresReadResult::FINISHED;`
	`368`	`+`
	`369`	`+ bool finished = row_offset >= result->Count();`
	`370`	`+ if (finished) {`
	`371`	`+ // The result set is fully consumed. Reset immediately to free the PGresult.`
	`372`	`+ Reset();`
	`373`	`+ return PostgresReadResult::FINISHED;`
	`374`	`+ }`
	`375`	`+ return PostgresReadResult::HAVE_MORE_TUPLES;`
`369`	`376`	`}`
`370`	`377`
`371`	`378`	`void PostgresTextReader::Reset() {`