clean up the code a little bit

Author: Tmonster

src/scan.cpp

@@ -153,7 +153,7 @@ void AppendAnyColumnSegment(const RType &rtype, bool experimental, data_ptr_t co
 		utf8proc_option_t options = (UTF8PROC_NULLTERM);
 		auto res = utf8proc_map(str, 0, &new_string, options);
 		if (res == UTF8PROC_ERROR_INVALIDUTF8) {
-			throw InternalException("rapi_execute: Cannot process strings that are not valid utf8: %s", string_val);
+			throw InvalidInputException("Strings \"%s\" is not valid utf8", (char*)string_val);
 		}
 
 		if (experimental) {

tests/testthat/test_strings.R

@@ -1,7 +1,12 @@
+library(duckdb)
+
 test_that("Invalid unicode produces an error", {
-  con <- dbConnect(duckdb())
-  on.exit(dbDisconnect(con, shutdown = TRUE))
+  con <- DBI::dbConnect(duckdb::duckdb())
 
   my_df <- structure(list(no_municipio_esc = "Est\xe2ncia", no_municipio_prova = "Est\xe2ncia"), row.names = 16L, class = "data.frame")
-  expect_error(DBI::dbWriteTable( con , 'my_table' , my_df ), "Cannot process strings that are not valid", ignore.case = TRUE)
+  expect_error(dbWriteTable(con , 'my_table' , my_df ))
+
+  # test that the connection still works.
+  dbWriteTable(con, 'myTable', data.frame(a=c(1, 2, 3), b=c(4, 5, 6)))
+  DBI::dbDisconnect(con, shutdown = TRUE)
 })