-
Notifications
You must be signed in to change notification settings - Fork 43
feat: more robust host config #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nelsonic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gf3, 👋
Thanks for opening this feedback / enhancement PR. 👌
The build fails because the version of Elixir cannot be loaded:
https://github.com/dwyl/elixir-auth-google/actions/runs/3993114722/jobs/6850008087#step:3:737

I've asked @SimonLab to help with #73 and we will update the version of OTP in ci.yml so the build should pass again. Hang tight. ⏳
|
I've created this PR #76 to fix the CI and tests. Once merged you should be able to rebase your PR. |
Thank you 🙏 Also, this is a wonderfully simply package—it is much appreciated. |
Attempt to both: 1. Use the provided scheme from the conn if available 2. Include all ports except 80
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 28 32 +4
=========================================
+ Hits 28 32 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nelsonic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gf3 thanks very much for creating this PR to improve the package. 🎉
It's always great to know people are actually using the code we've written ... 🚀
Your additions are good and tests are succinct. ✅
My only "feedback" is:
- Please create an issue to describe the problem you are facing before creating a PR.
- Add some sort of docs/usage for the change you made to the
README.mdso that other people using the package know that they can do the subdomain routing.
Other than that. Great work! 🙌
Welcome to @dwyl you now have write-access to everything! 📝
See:
|
Package published to https://hex.pm/packages/elixir_auth_google/1.6.4 📦 contains these updates. 🚀 |
|
Thank YOU 🫡 |
Changes
Attempt to both:
Purpose
Two reasons:
<id>.local.dev:4000)