From b0ea7ed11faf69c05f19d0b79b952f3d7841d9de Mon Sep 17 00:00:00 2001 From: Jason Irish Date: Wed, 3 Sep 2025 12:07:27 -0500 Subject: [PATCH 1/2] Update TextCheckboxGroupField to use natural TitleShowTitle field naming - Use TextCheckboxGroupField::create('Title') instead of ->setName('Title') - This creates 'TitleShowTitle' field name naturally - Ensures consistency with CustomStylesExtension positioning logic - Part of unified approach across BaseElementObject descendants --- src/Model/BaseElementObject.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Model/BaseElementObject.php b/src/Model/BaseElementObject.php index d16678a..bf3b0e5 100644 --- a/src/Model/BaseElementObject.php +++ b/src/Model/BaseElementObject.php @@ -134,8 +134,7 @@ public function getCMSFields() $fields->removeByName('ShowTitle'); $fields->replaceField( 'Title', - TextCheckboxGroupField::create() - ->setName('Title') + TextCheckboxGroupField::create('Title') ->setTitle($this->fieldLabel('Title')) ); From 03f3b0510421c6355abd563522dc7c711fc8623f Mon Sep 17 00:00:00 2001 From: Jason Irish Date: Wed, 3 Sep 2025 12:17:11 -0500 Subject: [PATCH 2/2] remove codecov --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 19f7e63..bf02210 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,5 +9,3 @@ jobs: ci: name: CI uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1 - with: - phpcoverage: true