Upgrade to Silverstripe 6 (#51)

* Update composer to be compatible with SS6

* fix getCMSField to be compatible with parent class

* update array syntax

* use self::class instead of __CLASS__ constant

Author: wernerkrauss

composer.json

@@ -26,12 +26,12 @@
         }
     ],
     "require": {
-        "dnadesign/silverstripe-elemental": "^5",
-        "dynamic/silverstripe-elemental-baseobject": "^5",
-        "jonom/focuspoint": "^5.0"
+        "dnadesign/silverstripe-elemental": "^6",
+        "dynamic/silverstripe-elemental-baseobject": "^6",
+        "jonom/focuspoint": "^6"
     },
     "require-dev": {
-        "silverstripe/recipe-testing": "^3"
+        "silverstripe/recipe-testing": "^4"
     },
     "minimum-stability": "dev",
     "prefer-stable": true,
@@ -49,4 +49,4 @@
         },
         "process-timeout": 600
     }
-}
+}

src/Elements/ElementPromos.php

@@ -43,7 +43,7 @@ class ElementPromos extends BaseElement
     /**
      * @var array
      */
-    private static $styles = array();
+    private static $styles = [];
 
     /**
      * @var array
@@ -55,18 +55,18 @@ class ElementPromos extends BaseElement
     /**
      * @var array
      */
-    private static $many_many = array(
+    private static $many_many = [
         'Promos' => PromoObject::class,
-    );
+    ];
 
     /**
      * @var array
      */
-    private static $many_many_extraFields = array(
-        'Promos' => array(
+    private static $many_many_extraFields = [
+        'Promos' => [
             'SortOrder' => 'Int',
-        ),
-    );
+        ],
+    ];
 
     /**
      * @var array
@@ -88,19 +88,21 @@ class ElementPromos extends BaseElement
      * @param bool $includerelations
      * @return array
      */
+    #[\Override]
     public function fieldLabels($includerelations = true)
     {
         $labels = parent::fieldLabels($includerelations);
 
-        $labels['Content'] = _t(__CLASS__.'.ContentLabel', 'Intro');
-        $labels['Promos'] = _t(__CLASS__ . '.PromosLabel', 'Promos');
+        $labels['Content'] = _t(self::class.'.ContentLabel', 'Intro');
+        $labels['Promos'] = _t(self::class . '.PromosLabel', 'Promos');
 
         return $labels;
     }
 
     /**
      * @return FieldList
      */
+    #[\Override]
     public function getCMSFields()
     {
         $this->beforeUpdateCMSFields(function (FieldList $fields) {
@@ -117,13 +119,14 @@ public function getCMSFields()
                     GridFieldDeleteAction::class,
                     GridFieldArchiveAction::class,
                 ])->addComponents(
-                    new GridFieldOrderableRows('SortOrder'),
-                    new GridFieldAddExistingSearchButton()
+                    GridFieldOrderableRows::create('SortOrder'),
+                    GridFieldAddExistingSearchButton::create()
                 );
 
-                $fields->addFieldsToTab('Root.Main', array(
+
+                $fields->addFieldsToTab('Root.Main', [
                     $promoField,
-                ));
+                ]);
             }
         });
 
@@ -141,6 +144,7 @@ public function getPromoList()
     /**
      * @return DBHTMLText
      */
+    #[\Override]
     public function getSummary()
     {
         $count = $this->Promos()->count();
@@ -149,13 +153,14 @@ public function getSummary()
             'A promo|{count} promos',
             [ 'count' => $count ]
         );
-        
+
         return DBField::create_field('HTMLText', $label)->Summary(20);
     }
 
     /**
      * @return array
      */
+    #[\Override]
     protected function provideBlockSchema()
     {
         $blockSchema = parent::provideBlockSchema();
@@ -166,8 +171,9 @@ protected function provideBlockSchema()
     /**
      * @return string
      */
+    #[\Override]
     public function getType()
     {
-        return _t(__CLASS__.'.BlockType', 'Promos');
+        return _t(self::class.'.BlockType', 'Promos');
     }
 }

src/Model/PromoObject.php

@@ -28,9 +28,9 @@ class PromoObject extends BaseElementObject
     /**
      * @var array
      */
-    private static $belongs_many_many = array(
+    private static $belongs_many_many = [
         'ElementPromos' => ElementPromos::class,
-    );
+    ];
 
     /**
      * @var string
@@ -49,7 +49,8 @@ class PromoObject extends BaseElementObject
      *
      * @throws \Exception
      */
-    public function getCMSFields()
+    #[\Override]
+    public function getCMSFields(): FieldList
     {
         $this->beforeUpdateCMSFields(function (FieldList $fields) {
             $fields->removeByName('ElementPromos');