Refs #20419: Fix TypeIdentifier comparation in TypeObject tests. #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLBuenoLopez
suggested changes
Feb 12, 2024
adriancampo
force-pushed
the
bugfix/typeidentifier_comparator
branch
from
0bc433c to
2141f05
Compare
adriancampo
changed the base branch from
feature/xtypes_typeobject
to
hotfix/typeobjectpair-api
Comment on lines
+713
to
+716
| EXPECT_TRUE(compare_type_identifiers(member_type_ids.type_identifier1(), type_objects.minimal_type_object.minimal().struct_type().member_seq()[pos].common().member_type_id()) || | ||
| compare_type_identifiers(member_type_ids.type_identifier1(), type_objects.complete_type_object.complete().struct_type().member_seq()[pos].common().member_type_id())); | ||
| EXPECT_TRUE(compare_type_identifiers(member_type_ids.type_identifier2(), type_objects.minimal_type_object.minimal().struct_type().member_seq()[pos].common().member_type_id()) || | ||
| compare_type_identifiers(member_type_ids.type_identifier2(), type_objects.complete_type_object.complete().struct_type().member_seq()[pos].common().member_type_id())); |
There was a problem hiding this comment.
The same issue is probably going to be happening with union members. Would you mind adding a test case and checking?
There was a problem hiding this comment.
added in 1992c80
JLBuenoLopez
force-pushed
the
hotfix/typeobjectpair-api
branch
from
519f368 to
1c47438
Compare
JLBuenoLopez
force-pushed
the
hotfix/typeobjectpair-api
branch
from
1c47438 to
6ff469d
Compare
adriancampo
force-pushed
the
bugfix/typeidentifier_comparator
branch
5 times, most recently
from
e489ef7 to
1992c80
Compare
JLBuenoLopez
force-pushed
the
hotfix/typeobjectpair-api
branch
from
6ff469d to
b0c34f2
Compare
adriancampo
force-pushed
the
bugfix/typeidentifier_comparator
branch
from
1992c80 to
1fa1435
Compare
* Refs #19451. Support new fastdds naming Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451. Fix in swig cmake files Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: EduPonz <[email protected]>
* Refs #19452: Run Fast DDS Gen CI on PRs to 4.0.x-devel Signed-off-by: EduPonz <[email protected]> * Refs #19452: Refactor CI Signed-off-by: EduPonz <[email protected]> * Refs #19452: Fix input Signed-off-by: EduPonz <[email protected]> * Refs #19452: Fix base branch decision making Signed-off-by: EduPonz <[email protected]> * Refs #19452: Select correct branches of the other repos Signed-off-by: EduPonz <[email protected]> * Refs #19452: Correctly fetch specified Fast CDR version Signed-off-by: EduPonz <[email protected]> * Refs #20640: Tmp disable ccache Signed-off-by: Mario Dominguez <[email protected]> * Revert "Refs #20640: Tmp disable ccache" This reverts commit 0927df5. --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
* Refs #20566: Change headers md5.h and SerializedPayload.h from fastrtps tp fastdds Signed-off-by: elianalf <[email protected]> * Refs #20566: Change header fixed_size_string Signed-off-by: elianalf <[email protected]> * Refs #20566: Change fixed_size_string namespace from fastrtps to fastcdr Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]>
* Refs #19944. Initial -genapi Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19944. Remove default templates Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19944. Update scope when getting typecodes Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19944. Fix compilation error Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19944. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
…ember (#262) * Refs #19932: update IDL parser submodule Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19932: changes required from review suggestion in IDL Parser Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19932: update submodule Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
* Refs #19971. Remove -cdr argument Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19971. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #19960. Implementation Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. New argument -no-typesupport Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Remove old template Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. New configuration to set explicitly using modules in stg Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #20003. Fix warnings. Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20003: do not generate empty namespaces Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20003. Fix warnings and new ReturnCode_t Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
* Refs #20052: fix tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20052: update submodule Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
* Refs #20056. Argument to change max size of unbounded containers Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20056. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #19837: fix Clang warning, unused lambda capture Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: update dds types test submodule Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
* Refs #20063. Support for C++ enum class Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20063. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20063. Update submodule and use Context Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20063. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #20070. Using includes which will be used Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20070. Fix enum casting Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20070. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #20070. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20070. Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #20533: Fixed tests for member_id of unions. Signed-off-by: adriancampo <[email protected]> * Refs #20533: Fix for maps equiv_kind. Signed-off-by: adriancampo <[email protected]> * Refs #20533: Removed unnecessary checks. Signed-off-by: adriancampo <[email protected]> * Refs #20533: Updated submodule. Signed-off-by: adriancampo <[email protected]> * Refs #20533: Added check for id2. Signed-off-by: adriancampo <[email protected]> * Refs #20533: Added check for TK_NONE keys Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]>
* Refs #19451. Support new fastdds naming Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451. Fix in swig cmake files Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
* Refs #19451. First implementation Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451. Fixes Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451. Remove not needed functions on template Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451. Remove unused template macros Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451.- Fix externals Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451.- Fix fixed_string Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451.- Fix warnings Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19451.- Update submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]>
JLBuenoLopez
force-pushed
the
hotfix/typeobjectpair-api
branch
from
b0c34f2 to
62c85e3
Compare
* Refs #20335: fix TypeObjectPair API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20335: use new Fast DDS headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Base automatically changed from
hotfix/typeobjectpair-api
to
feature/xtypes_typeobject
April 4, 2024 06:59
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
adriancampo
force-pushed
the
bugfix/typeidentifier_comparator
branch
from
1fa1435 to
ba7f9e9
Compare
richiware
force-pushed
the
feature/xtypes_typeobject
branch
2 times, most recently
from
36e063d to
08dfbb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs eProsima/dds-types-test#24