Skip to content

Conversation

@depink5
Copy link
Contributor

@depink5 depink5 commented Apr 3, 2025

Description

This PR adds the Version of Fast DDS-Gen to the generated code.

@Mergifyio backport 4.0.x 3.3.x 2.5.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@depink5 depink5 force-pushed the feature/add_version_to_code branch from d639e27 to 3bc56c2 Compare April 3, 2025 10:48
@depink5 depink5 requested a review from Carlosespicur April 3, 2025 10:56
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 3, 2025
@depink5 depink5 requested review from Copilot and removed request for Carlosespicur April 3, 2025 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg: Language not supported
Comments suppressed due to low confidence (1)

src/main/java/com/eprosima/fastdds/idl/grammar/Context.java:484

  • Consider checking whether 'input' is null before calling methods like available() to prevent a potential NullPointerException when the resource is missing.
InputStream input = this.getClass().getClassLoader().getResourceAsStream("version");

@eProsima eProsima deleted a comment from Copilot AI Apr 8, 2025
@MiguelCompany MiguelCompany added this to the v4.1.0 milestone Apr 8, 2025
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit a2ff4a4 into master Apr 9, 2025
4 of 6 checks passed
@MiguelCompany MiguelCompany deleted the feature/add_version_to_code branch April 9, 2025 10:17
@MiguelCompany
Copy link
Member

@Mergifyio backport 4.0.x 3.3.x 2.5.x 2.1.x

@mergify
Copy link

mergify bot commented Apr 9, 2025

backport 4.0.x 3.3.x 2.5.x 2.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 9, 2025
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
Signed-off-by: Denisa <[email protected]>
(cherry picked from commit a2ff4a4)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
Signed-off-by: Denisa <[email protected]>
(cherry picked from commit a2ff4a4)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/idl/grammar/Context.java
#	src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg
MiguelCompany pushed a commit that referenced this pull request Apr 25, 2025
Signed-off-by: Denisa <[email protected]>
(cherry picked from commit a2ff4a4)

Co-authored-by: Denisa Alexandru <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Apr 25, 2025
Signed-off-by: Denisa <[email protected]>
(cherry picked from commit a2ff4a4)

Co-authored-by: Denisa Alexandru <[email protected]>
MiguelCompany added a commit that referenced this pull request May 27, 2025
* Sign the generated code with the Fast DDS-Gen version (#458)

Signed-off-by: Denisa <[email protected]>
(cherry picked from commit a2ff4a4)

# Conflicts:
#	src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg

* Fix conflicts.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Denisa Alexandru <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants