Skip to content

Commit f8a9601

Browse files
committed
Remove brittle stringy checks
1 parent 654d94a commit f8a9601

File tree

6 files changed

+7
-92
lines changed

6 files changed

+7
-92
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66

77
jobs:
8-
stringy-check:
8+
repo-checks:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v4
@@ -31,11 +31,6 @@ jobs:
3131
run: cargo install modum --locked
3232
- name: Modum
3333
run: cargo modum check --root . --mode warn
34-
- name: advisory stringy checks
35-
continue-on-error: true
36-
run: scripts/ci/stringy-check.sh
37-
- name: no String fields
38-
run: scripts/ci/no-string-fields.sh
3934
- name: enum + builder contract
4035
run: scripts/ci/enum-builder-contract.sh
4136
- name: bon usage contract

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ This repo has two documentation layers:
6060
## Release Gate
6161

6262
- Before downstream publish or accept steps, run `bash scripts/check_publish_dry_run.sh`.
63-
- That gate includes both local workspace tests and a local `act -j stringy-check` run against the repo CI workflow.
63+
- That gate includes both local workspace tests and a local `act -j repo-checks` run against the repo CI workflow.
6464

6565
## Suggested Reading Paths
6666

docs/project-audit.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ Static review:
2828
Execution checks:
2929
- `cargo check` (pass)
3030
- `cargo test --workspace` (pass, 14 tests)
31-
- `bash scripts/ci/no-string-fields.sh` (pass)
3231
- `bash scripts/ci/partials-render.sh` (pass)
33-
- `bash scripts/ci/stringy-check.sh` (fail)
3432
- `cargo-clippy --workspace --all-targets -- -D warnings` with `RUSTC_WRAPPER=` (fail, multiple findings)
3533
- `cargo-fmt --all -- --check` via `cargo-fmt` (fail)
3634

35+
Historical note:
36+
- The former `scripts/ci/no-string-fields.sh` and `scripts/ci/stringy-check.sh` checks referenced by this audit were removed in March 2026 after proving too brittle and low-signal for repo-wide CI.
37+
3738
## Boundary Map
3839
- `domain`: invariants and core types (`Username`, `Email`, chat IDs, statuses). No serde leakage in domain entities.
3940
- `app`: use-case orchestration and traits (`Repository`, `PasswordHasher`, `RateLimiter`, etc.).
@@ -233,7 +234,7 @@ Severity: Low
233234

234235
Evidence:
235236
- `crates/http/src/views/partials/demo/layout/capability_showcase.rs:58`
236-
- `scripts/ci/stringy-check.sh`
237+
- former `scripts/ci/stringy-check.sh`
237238

238239
Details:
239240
- `Text::from("==")` triggers `contains("...")` pattern in guardrail script.

scripts/check_publish_dry_run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ echo "Running workspace tests (without doctests)..."
2323
cargo test --workspace --lib --tests
2424

2525
echo "Running local GitHub Actions gate under act..."
26-
act -j stringy-check
26+
act -j repo-checks

scripts/ci/no-string-fields.sh

Lines changed: 0 additions & 23 deletions
This file was deleted.

scripts/ci/stringy-check.sh

Lines changed: 0 additions & 58 deletions
This file was deleted.

0 commit comments

Comments
 (0)