Skip to content

Commit 6fb807e

Browse files
committed
fix comment and css classes of component
1 parent 123c3cd commit 6fb807e

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

src/components/DecoupledOverlay/DecoupledOverlay.tsx

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ import { createPopper } from "@popperjs/core";
66
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
77
import { ContextOverlayProps, TestableComponent, TooltipSize } from "../../index";
88

9-
/**
10-
* Overlay without the necessity to use a target that need to be rendered in place.
11-
* The target is referenced by a selector string or element object.
12-
* It can exist somewhere in the DOM, but it must exist when the overlay is rendered.
13-
* It is always displayed, close it by removement.
14-
*/
159
export interface DecoupledOverlayProps
1610
extends React.HTMLAttributes<HTMLDivElement>,
1711
TestableComponent,
@@ -26,7 +20,12 @@ export interface DecoupledOverlayProps
2620
size?: TooltipSize;
2721
}
2822

29-
/** Popover that is displayed and points at the highlighted element. */
23+
/**
24+
* Use an overlay popover without the necessity to use a target that need to be rendered in place.
25+
* The target is referenced by a selector string or element object.
26+
* It can exist somewhere in the DOM, but it must exist when the overlay is rendered.
27+
* It is always displayed, close it by removement.
28+
*/
3029
export const DecoupledOverlay = ({
3130
targetSelectorOrElement,
3231
usePortal = true,
@@ -62,8 +61,8 @@ export const DecoupledOverlay = ({
6261
const overlay = (
6362
<div
6463
className={
65-
`${eccgui}-visual-tour__overlay` +
66-
` ${eccgui}-visual-tour__overlay--${size}` +
64+
`${eccgui}-decoupled-overlay` +
65+
` ${eccgui}-decoupled-overlay--${size}` +
6766
` ${BlueprintClasses.POPOVER}` +
6867
(minimal ? ` ${BlueprintClasses.MINIMAL}` : "")
6968
}
@@ -72,14 +71,12 @@ export const DecoupledOverlay = ({
7271
>
7372
{!minimal && (
7473
<div
75-
className={`${eccgui}-visual-tour__arrow ${BlueprintClasses.POPOVER_ARROW}`}
74+
className={`${eccgui}-decoupled-overlay__arrow ${BlueprintClasses.POPOVER_ARROW}`}
7675
data-popper-arrow
7776
aria-hidden
7877
/>
7978
)}
80-
<div className={`${BlueprintClasses.POPOVER_CONTENT} ${eccgui}-visual-tour__overlay__content`}>
81-
{children}
82-
</div>
79+
<div className={`${BlueprintClasses.POPOVER_CONTENT} ${eccgui}-decoupled-overlay__content`}>{children}</div>
8380
</div>
8481
);
8582

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
.#{$eccgui}-visual-tour__arrow {
1+
.#{$eccgui}-decoupled-overlay__arrow {
22
&::before {
33
background: $card-background-color;
44
}
55

6-
.#{$eccgui}-visual-tour__overlay[data-popper-placement="top"] & {
6+
.#{$eccgui}-decoupled-overlay[data-popper-placement="top"] & {
77
bottom: -0.5 * $eccgui-size-block-whitespace;
88
}
9-
.#{$eccgui}-visual-tour__overlay[data-popper-placement="right"] & {
9+
.#{$eccgui}-decoupled-overlay[data-popper-placement="right"] & {
1010
left: -0.5 * $eccgui-size-block-whitespace;
1111
}
12-
.#{$eccgui}-visual-tour__overlay[data-popper-placement="bottom"] & {
12+
.#{$eccgui}-decoupled-overlay[data-popper-placement="bottom"] & {
1313
top: -0.5 * $eccgui-size-block-whitespace;
1414
}
15-
.#{$eccgui}-visual-tour__overlay[data-popper-placement="left"] & {
15+
.#{$eccgui}-decoupled-overlay[data-popper-placement="left"] & {
1616
right: -0.5 * $eccgui-size-block-whitespace;
1717
}
1818
}
1919

20-
.#{$eccgui}-visual-tour__overlay {
20+
.#{$eccgui}-decoupled-overlay {
2121
&.#{$prefix-blueprintjs}-popover {
2222
z-index: 8002; // 2 over application header
2323
}
@@ -34,13 +34,13 @@
3434
@extend .#{$eccgui}-tooltip--large;
3535
}
3636

37-
&:has(.#{$eccgui}-visual-tour__arrow) {
38-
.#{$eccgui}-visual-tour__overlay__content {
37+
&:has(.#{$eccgui}-decoupled-overlay__arrow) {
38+
.#{$eccgui}-decoupled-overlay__content {
3939
min-height: 30px; // height of blueprint arrow
4040
}
4141
}
4242
}
4343

44-
.#{$eccgui}-visual-tour__overlay__content {
44+
.#{$eccgui}-decoupled-overlay__content {
4545
padding: 0.1px; // force margins of children to stay inside
4646
}

0 commit comments

Comments
 (0)