Add Wayland to build matrix on GitHub actions #2768
Conversation
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
1bddc88 to
45ee541
Compare
|
On most recent Ubuntu/Fedora/etc. distros users get Wayland session by default thus I would say that even on Gtk3 Wayland has become the most common setup. |
|
I am open to whatever collection of backends/gtk versions. For now this PR tests as before plus GTK4 on wayland. We could enable all 6 - I don't want to overwhelm the number of builds that run if it isn't valuable enough. |
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
45ee541 to
00d3b0c
Compare
|
@akurtakov I split out the question of which combinations to exclude to a future commit - this PR tests all of the valid combinations. Comment 0 and commit message updated. |
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
3 times, most recently
from
fa6418f to
0e5ce32
Compare
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
0e5ce32 to
1bf73d6
Compare
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
1bf73d6 to
fae431b
Compare
|
The JVM crashes are a corner case that I will workaround because IMHO they are bugs in GTK not in SWT: #2853 |
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
3 times, most recently
from
807d6c3 to
0b53193
Compare
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
7 times, most recently
from
2a35daa to
9adabe0
Compare
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
9adabe0 to
94b21d3
Compare
|
I have given up - for now at least - getting tests reliable on gtk3+wayland. As it turns out GTK3 itself is only tested on x11. GTK4 is tested on x11, wayland, and broadway. I have therefore excluded the gtk3/wayland combination and I open this up for review now. |
|
I plan to merge this soon if there are no objections. |
|
Only thing left is to update commit message to reflect final state. I will do that when I rebase it on top of #2764 |
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
94b21d3 to
057f185
Compare
Add GDK_BACKEND environment variable setting and corresponding entry in the Linux matrix entry for wayland and x11. There are a total of 4 combinations possible of GTK version and backend: - GTK3 x11 (uses Xvfb) - GTK3 wayland (uses mutter headless) - GTK4 x11 (uses Xvfb) - GTK4 wayland (uses mutter headless) Prior to this commit only the x11 variants were tested. This commit enables wayland for both GTK3 + GTK4, however it is expected subsequent commits will limit the matrix to exclude GTK3+wayland. Part of eclipse-platform#2714
jonahgraham
force-pushed
the
wayland-matrix-entry
branch
from
057f185 to
5e42348
Compare
|
I updated commit messages and the original PR comment #2768 (comment) |
2 participants
Add Wayland to build matrix on GitHub actions
Add GDK_BACKEND environment variable setting and corresponding entry in the Linux matrix entry for wayland and x11.
There are a total of 4 combinations possible of GTK version and backend:
Prior to this PR only the x11 variants were tested. With this PR GTK4 on Wayland is also tested. GTK3 on wayland is too unreliable under tests at the moment and is excluded.
Part of #2714