-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add support for forcings in SimpleRunner #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
b8raoult
wants to merge
2
commits into
main
Choose a base branch
from
feat/simple-runner-and-forcings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,14 @@ | |
| # granted to it by virtue of its status as an intergovernmental organisation | ||
| # nor does it submit to any jurisdiction. | ||
|
|
||
|
|
||
| import logging | ||
| from typing import Any | ||
|
|
||
| import numpy as np | ||
|
|
||
| from anemoi.inference.context import Context | ||
| from anemoi.inference.types import Date | ||
| from anemoi.inference.types import FloatArray | ||
| from anemoi.inference.types import IntArray | ||
| from anemoi.inference.types import State | ||
|
|
||
|
|
@@ -58,11 +62,26 @@ def load_forcings_state(self, state: State, date: str) -> None: | |
| pass | ||
|
|
||
|
|
||
| class UserProvidedForcings(Forcings): | ||
| trace_name = "user_provided" | ||
|
|
||
| def __init__(self, context: Context, forcings, variables: list[str], mask: IntArray): | ||
| super().__init__(context) | ||
| self.variables = variables | ||
| self.mask = mask | ||
| self.forcings = forcings | ||
|
|
||
| def load_forcings_array(self, dates: list[Date], current_state: State) -> FloatArray: | ||
| indices = [self.forcings["dates"].index(d) for d in dates] | ||
| result = np.stack([self.forcings["fields"][var][indices] for var in self.variables], axis=0) | ||
| return result.astype(np.float32) | ||
|
|
||
|
|
||
| @runner_registry.register("simple") | ||
| class SimpleRunner(Runner): | ||
| """Use that runner when using the low level API.""" | ||
|
|
||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
| def __init__(self, *args: Any, forcings: dict[str, Any] | None = None, **kwargs: Any) -> None: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is any here correct? |
||
| """Initialize the SimpleRunner. | ||
|
|
||
| Parameters | ||
|
|
@@ -73,6 +92,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None: | |
| Keyword arguments. | ||
| """ | ||
| super().__init__(*args, **kwargs) | ||
| self.forcings = forcings | ||
|
|
||
| def create_constant_computed_forcings(self, variables: list[str], mask: IntArray) -> list[Forcings]: | ||
| """Create constant computed forcings. | ||
|
|
@@ -151,5 +171,6 @@ def create_dynamic_coupled_forcings(self, variables: list[str], mask: IntArray) | |
| # This runner does not support coupled forcings | ||
| # there are supposed to be already in the state dictionary | ||
| # or managed by the user. | ||
| LOG.warning("Coupled forcings are not supported by this runner: %s", variables) | ||
| return [] | ||
| # LOG.warning("Coupled forcings are not supported by this runner: %s", variables) | ||
|
|
||
| return [UserProvidedForcings(self, self.forcings, variables, mask)] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
forcingsbe type hinted?