Change some code to better match the tutorials #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oder.io Also change "f.write(geojson.dumps(geo_map))" to "f.write(g.dumps(geo_map))"
|
Hi, thanks for the patch! In my opinion it would be better to not use aliases: it’s easier to understand “geojson.some_function” deep in the module rather than having to go back to imports to see what “g” is. (There is an exception for example for scientific Python code, where modules have common aliases used consistently: np for numpy, pd for pandas, etc.) Do you think that changing the other text (from g to geojson) would be better? @econchick do you have a strong preference either way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change line "import geojson" to "import geojson as g" to reflect newcoder.io
Also change "f.write(geojson.dumps(geo_map))" to "f.write(g.dumps(geo_map))"