Chart builders with data parameter for all charttypes

[HoldYourWaffle]

Is there a reason why only the piechart builder has a data parameter?

tornadofx/src/main/java/tornadofx/Charts.kt

Lines 7 to 14 in e63f086

	/**
	* Create a PieChart with optional title data and add to the parent pane. The optional op will be performed on the new instance.
	*/
	fun EventTarget.piechart(title: String? = null, data: ObservableList<PieChart.Data>? = null, op: PieChart.() -> Unit = {}): PieChart {
	val chart = if (data != null) PieChart(data) else PieChart()
	chart.title = title
	return opcr(this, chart, op)
	}

tornadofx/src/main/java/tornadofx/Charts.kt

Lines 33 to 37 in e63f086

	/**
	* Create a LineChart with optional title, axis and add to the parent pane. The optional op will be performed on the new instance.
	*/
	fun <X, Y> EventTarget.linechart(title: String? = null, x: Axis<X>, y: Axis<Y>, op: LineChart<X, Y>.() -> Unit = {}) =
	LineChart<X, Y>(x, y).attachTo(this, op) { it.title = title }

[edvin]

I believe that's because PieChart only has a single dimension, whereas the other charts support multiple dimensions so it's more convenient to generate series of data using the series builder after creating the chart.

[HoldYourWaffle]

That makes sense. However, in my application the Series are generated programmatically too, so I'm directly binding data to an ObservableList<XYChart.Serie> like this (pseudo-code):

val series = observableListOf<XYChart.Serie>();

linechart {
    data.bind(series);
}

Would it make sense to add a convenience constructor parameter for this use-case?

[edvin]

Sure :) It's in line with how the other builders work, so a PR would be welcome :)

[ctadlock]

@HoldYourWaffle I’ll get this merged in. Can you also submit one for the jdk10 branch to make it easy? ;)

[HoldYourWaffle]

@ctadlock Here you go