Attempt with images again.

Author: simonge

benchmarks/lowq2_reconstruction/PRfunctions.py

@@ -13,6 +13,31 @@
 # Utility Functions
 # =============================================================================
 
+def create_data_uri_from_file(image_path):
+    """Read an image file and convert to base64 data URI"""
+    if not os.path.exists(image_path):
+        print(f"⚠️ Image file not found: {image_path}")
+        return None
+    
+    try:
+        with open(image_path, 'rb') as f:
+            image_data = f.read()
+        
+        # Encode to base64
+        b64_data = base64.b64encode(image_data).decode('utf-8')
+        
+        # Determine mime type from extension
+        ext = Path(image_path).suffix.lower()
+        mime_type = 'image/png' if ext == '.png' else 'image/jpeg' if ext in ['.jpg', '.jpeg'] else 'image/png'
+        
+        data_uri = f"data:{mime_type};base64,{b64_data}"
+        
+        print(f"✅ Created data URI for {image_path} (size: {len(data_uri)} chars)")
+        return data_uri
+    except Exception as e:
+        print(f"❌ Failed to create data URI for {image_path}: {e}")
+        return None
+
 def parse_repository(repository):
     """Parse repository string into owner and name"""
     try:
@@ -154,7 +179,7 @@ def find_line_number_of_change(original_content, old_value):
 # GitHub PR Comment Functions
 # =============================================================================
 
-def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, head_sha, github_token, artifacts_url=''):
+def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, head_sha, github_token, before_images=None, after_images=None, artifacts_url=''):
     """Create a PR comment with proposed changes"""
     print(f"Creating PR comment with calibration update for #{pr_number}...")
 
@@ -196,9 +221,31 @@ def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml
 
 Please update the calibration URL in `{xml_file}` at line {line_number}."""
 
-    # Add artifacts link if provided
+    # Convert image file paths to data URIs and embed
+    if before_images:
+        comment_body += "\n\n---\n\n### 📊 Before Calibration Update\n\n"
+        for img_path in before_images:
+            data_uri = create_data_uri_from_file(img_path)
+            if data_uri:
+                comment_body += f"![Before Image]({data_uri})\n\n"
+
+    if after_images:
+        comment_body += "\n\n---\n\n### ✨ After Calibration Update\n\n"
+        for img_path in after_images:
+            data_uri = create_data_uri_from_file(img_path)
+            if data_uri:
+                comment_body += f"![After Image]({data_uri})\n\n"
+    
+    # Add artifacts URL link if provided
     if artifacts_url:
-        comment_body += f"\n\n---\n\n### 📊 Review Results\n\nPlease review the artifacts here: {artifacts_url}"
+        comment_body += f"\n\n---\n\n📁 For comprehensive results and full-resolution artifacts, please visit: [{artifacts_url}]({artifacts_url})\n\n"
+    
+    # Check total comment size
+    comment_size = len(comment_body)
+    print(f"Total comment size: {comment_size} characters")
+    if comment_size > 65536:
+        print(f"⚠️ WARNING: Comment exceeds GitHub's 65KB limit by {comment_size - 65536} characters!")
+        print("   Consider further compressing images or reducing resolution.")
 
     # Create or update comment via GitHub REST API (no gh CLI)
     if existing_comment_id:

benchmarks/lowq2_reconstruction/config.yml

@@ -103,9 +103,22 @@ upload_onnx:lowq2_reconstruction:
     - echo "Updating PR with lowq2 reconstruction results"
     - echo "ONNX file will be available at $ONNX_UPLOAD_URL"
     - |
-      # Build artifact folder URL for review
+      # Compress images for data URI embedding in GitHub comment
+      BEFORE_IMG="results/lowq2_reconstruction/test_local/test_energy_theta_phi_resolution_local.png"
+      AFTER_IMG="results/lowq2_reconstruction/retrained_local/retrained_energy_theta_phi_resolution_local.png"
+      BEFORE_COMPRESSED="results/lowq2_reconstruction/test_local/compressed_test_energy_theta_phi.png"
+      AFTER_COMPRESSED="results/lowq2_reconstruction/retrained_local/compressed_retrained_energy_theta_phi.png"
+      
+      echo "Compressing images for data URI embedding..."
+      magick "$BEFORE_IMG" -resize 800x600 -strip -quality 20 -colors 8 "$BEFORE_COMPRESSED"
+      magick "$AFTER_IMG" -resize 800x600 -strip -quality 20 -colors 8 "$AFTER_COMPRESSED"
+      
+      echo "Before compressed: $(ls -lh $BEFORE_COMPRESSED | awk '{print $5}')"
+      echo "After compressed: $(ls -lh $AFTER_COMPRESSED | awk '{print $5}')"
+      
+      # Build artifacts URL
       ARTIFACTS_URL="${CI_PROJECT_URL}/-/jobs/${CI_JOB_ID}/artifacts/browse/results/lowq2_reconstruction/"
-      echo "Artifacts URL: $ARTIFACTS_URL"
+      echo "Artifacts will be available at: $ARTIFACTS_URL"
     - |
       python benchmarks/lowq2_reconstruction/makePRSuggestion.py \
         --pr 213 \
@@ -114,5 +127,7 @@ upload_onnx:lowq2_reconstruction:
         --calibrationFile calibrations/onnx/Low-Q2_Steering_Reconstruction.onnx \
         --xml benchmarks/lowq2_reconstruction/calibrations.xml \
         --repository eic/detector_benchmarks \
+        --beforeImages "$BEFORE_COMPRESSED" \
+        --afterImages "$AFTER_COMPRESSED" \
         --artifactsURL "$ARTIFACTS_URL"
     - echo "Updating GitHub status for lowq2 reconstruction"

benchmarks/lowq2_reconstruction/makePRSuggestion.py

@@ -14,7 +14,9 @@
 parser.add_argument('--calibrationFile', type=str, default='calibrations/onnx/Low-Q2_Steering_Reconstruction.onnx', help='Path to the local calibration file')
 parser.add_argument('--xml', type=str, default='compact/calibrations.xml', help='Path to the XML configuration file')
 parser.add_argument('--repository', type=str, default='eic/epic', help='GitHub repository (owner/name)')
-parser.add_argument('--artifactsURL', type=str, default='', help='URL to job artifacts for review')
+parser.add_argument('--beforeImages', type=str, nargs='*', default=[], help='List of before image file paths')
+parser.add_argument('--afterImages', type=str, nargs='*', default=[], help='List of after image file paths')
+parser.add_argument('--artifactsURL', type=str, default='', help='URL to job artifacts for additional review')
 
 
 args = parser.parse_args()
@@ -25,6 +27,8 @@
 calibration_file     = args.calibrationFile
 xml_file             = args.xml
 repository           = args.repository
+before_images        = args.beforeImages
+after_images         = args.afterImages
 artifacts_url        = args.artifactsURL
 
 # =============================================================================
@@ -63,7 +67,7 @@
     print(f"   Suggested change: {suggested_line.strip()}")
 
     # Create the PR comment with proposed changes
-    response = create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, pr_info['head']['sha'], github_token, artifacts_url)
+    response = create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, pr_info['head']['sha'], github_token, before_images, after_images, artifacts_url)
 
     if response:
         print("🎉 PR comment created successfully!")