Just link to the gitlab job artifacts directory

Author: simonge

benchmarks/lowq2_reconstruction/PRfunctions.py

@@ -154,7 +154,7 @@ def find_line_number_of_change(original_content, old_value):
 # GitHub PR Comment Functions
 # =============================================================================
 
-def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, head_sha, github_token, before_images=None, after_images=None):
+def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, head_sha, github_token, artifacts_url=''):
     """Create a PR comment with proposed changes"""
     print(f"Creating PR comment with calibration update for #{pr_number}...")
 
@@ -196,20 +196,12 @@ def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml
 
 Please update the calibration URL in `{xml_file}` at line {line_number}."""
 
-    # Add before images section if provided
-    if before_images:
-        comment_body += "\n\n---\n\n### 📊 Before Calibration Update\n\n"
-        for img_url in before_images:
-            comment_body += f"![Before Image]({img_url})\n\n"
-
-    # Add after images section if provided
-    if after_images:
-        comment_body += "\n\n---\n\n### 📈 After Calibration Update\n\n"
-        for img_url in after_images:
-            comment_body += f"![After Image]({img_url})\n\n"
+    # Add artifacts link if provided
+    if artifacts_url:
+        comment_body += f"\n\n---\n\n### 📊 Review Results\n\nPlease review the artifacts here: {artifacts_url}"
 
+    # Create or update comment via GitHub REST API (no gh CLI)
     if existing_comment_id:
-        # Update existing comment
         print(f"Updating existing comment {existing_comment_id}...")
         update_url = f"https://api.github.com/repos/{repo_owner}/{repo_name}/issues/comments/{existing_comment_id}"
         update_data = {'body': comment_body}
@@ -221,7 +213,6 @@ def create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml
             print(f"❌ Failed to update existing comment: {response.status_code}\n{response.text}")
             return None
     else:
-        # Create new regular PR comment
         print("Creating new PR comment...")
         comment_url = f"https://api.github.com/repos/{repo_owner}/{repo_name}/issues/{pr_number}/comments"
         comment_data = {'body': comment_body}

benchmarks/lowq2_reconstruction/config.yml

@@ -103,13 +103,9 @@ upload_onnx:lowq2_reconstruction:
     - echo "Updating PR with lowq2 reconstruction results"
     - echo "ONNX file will be available at $ONNX_UPLOAD_URL"
     - |
-      # Build GitLab artifact URLs for images from THIS job; links will work once the job finishes
-      BEFORE_IMG_PATH="results/lowq2_reconstruction/test_local/test_energy_theta_phi_resolution_local.png"
-      AFTER_IMG_PATH="results/lowq2_reconstruction/retrained_local/retrained_energy_theta_phi_resolution_local.png"
-      BEFORE_IMG_URL="${CI_PROJECT_URL}/-/jobs/${CI_JOB_ID}/artifacts/raw/${BEFORE_IMG_PATH}"
-      AFTER_IMG_URL="${CI_PROJECT_URL}/-/jobs/${CI_JOB_ID}/artifacts/raw/${AFTER_IMG_PATH}"
-      echo "Before image URL: $BEFORE_IMG_URL"
-      echo "After image URL: $AFTER_IMG_URL"
+      # Build artifact folder URL for review
+      ARTIFACTS_URL="${CI_PROJECT_URL}/-/jobs/${CI_JOB_ID}/artifacts/browse/results/lowq2_reconstruction/"
+      echo "Artifacts URL: $ARTIFACTS_URL"
     - |
       python benchmarks/lowq2_reconstruction/makePRSuggestion.py \
         --pr 213 \
@@ -118,6 +114,5 @@ upload_onnx:lowq2_reconstruction:
         --calibrationFile calibrations/onnx/Low-Q2_Steering_Reconstruction.onnx \
         --xml benchmarks/lowq2_reconstruction/calibrations.xml \
         --repository eic/detector_benchmarks \
-        --beforeImages "$BEFORE_IMG_URL" \
-        --afterImages "$AFTER_IMG_URL"
+        --artifactsURL "$ARTIFACTS_URL"
     - echo "Updating GitHub status for lowq2 reconstruction"

benchmarks/lowq2_reconstruction/makePRSuggestion.py

@@ -14,8 +14,7 @@
 parser.add_argument('--calibrationFile', type=str, default='calibrations/onnx/Low-Q2_Steering_Reconstruction.onnx', help='Path to the local calibration file')
 parser.add_argument('--xml', type=str, default='compact/calibrations.xml', help='Path to the XML configuration file')
 parser.add_argument('--repository', type=str, default='eic/epic', help='GitHub repository (owner/name)')
-parser.add_argument('--beforeImages', type=str, nargs='*', default=[], help='List of before image URLs or paths')
-parser.add_argument('--afterImages', type=str, nargs='*', default=[], help='List of after image URLs or paths')
+parser.add_argument('--artifactsURL', type=str, default='', help='URL to job artifacts for review')
 
 
 args = parser.parse_args()
@@ -26,8 +25,7 @@
 calibration_file     = args.calibrationFile
 xml_file             = args.xml
 repository           = args.repository
-before_images        = args.beforeImages
-after_images         = args.afterImages
+artifacts_url        = args.artifactsURL
 
 # =============================================================================
 
@@ -65,7 +63,7 @@
     print(f"   Suggested change: {suggested_line.strip()}")
 
     # Create the PR comment with proposed changes
-    response = create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, pr_info['head']['sha'], github_token, before_images, after_images)
+    response = create_pr_suggestion(repo_owner, repo_name, pr_number, calibration_file, xml_file, line_number, suggested_line, pr_info['head']['sha'], github_token, artifacts_url)
 
     if response:
         print("🎉 PR comment created successfully!")