chore(golangci-lint): fix lint violations

Author: ekristen

pkg/commands/list/list.go

@@ -29,13 +29,15 @@ func execute(c *cli.Context) error {
 		} else {
 			_, _ = color.New(color.Bold).Printf("%-55s", name)
 			c := color.FgGreen
-			if reg.Scope == azure.TenantScope {
+			switch reg.Scope {
+			case azure.TenantScope:
 				c = color.FgHiGreen
-			} else if reg.Scope == azure.SubscriptionScope {
+			case azure.SubscriptionScope:
 				c = color.FgHiBlue
-			} else if reg.Scope == azure.ResourceGroupScope {
+			case azure.ResourceGroupScope:
 				c = color.FgHiMagenta
 			}
+
 			_, _ = color.New(c).Printf("%s\n", string(reg.Scope))
 		}
 	}

resources/disk.go

@@ -88,7 +88,7 @@ func (l DiskLister) List(ctx context.Context, o interface{}) ([]resource.Resourc
 				client:       client,
 				Name:         r.Name,
 				Tags:         r.Tags,
-				CreationDate: ptr.Time(r.DiskProperties.TimeCreated.Time),
+				CreationDate: ptr.Time(r.TimeCreated.Time),
 			})
 		}
 

resources/security-alert.go

@@ -106,7 +106,7 @@ func (l SecurityAlertsLister) List(ctx context.Context, o interface{}) ([]resour
 				ID:          *g.ID,
 				Name:        *g.Name,
 				DisplayName: ptr.ToString(g.AlertDisplayName),
-				Status:      string(g.AlertProperties.Status),
+				Status:      string(g.Status),
 			})
 		}
 

resources/snapshot.go

@@ -88,7 +88,7 @@ func (l ComputeSnapshotLister) List(ctx context.Context, o interface{}) ([]resou
 				client:       client,
 				Name:         r.Name,
 				Tags:         r.Tags,
-				CreationDate: ptr.Time(r.SnapshotProperties.TimeCreated.Time),
+				CreationDate: ptr.Time(r.TimeCreated.Time),
 			})
 		}
 

resources/subscription-role-assignment.go

@@ -127,7 +127,7 @@ func (l *SubscriptionRoleAssignmentLister) List(ctx context.Context, o interface
 			}
 
 			if _, ok := l.roleNameCache[t.Properties.RoleDefinitionID]; !ok {
-				l.roleNameCache[t.Properties.RoleDefinitionID] = rel.RoleDefinition.Properties.RoleName
+				l.roleNameCache[t.Properties.RoleDefinitionID] = rel.Properties.RoleName
 			}
 
 			var principalName = ptr.String("unknown")