Skip to content

Commit 8c58270

Browse files
authored
Restore missing "skip windows" logic in test (#18724)
There is a comment to skip on windows, but we forgot to actually skip. Skip!
1 parent 7ba6f33 commit 8c58270

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

logstash-core/src/test/java/org/logstash/settings/WritableDirectorySettingTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ public void whenDirectoryMissingAndParentNotWritableThenValidateFails() throws I
213213
@Test
214214
public void whenDirectoryMissingAndParentNotWritableThenValidateValueFails() throws IOException {
215215
// Skip on Windows where chmod doesn't work the same way
216+
assumeTrue(isNotWindowsOS());
216217
assertFalse("Can't run as root since root can write anywhere (no real read-only files)", isRoot());
217218

218219
Path parentDir = tempFolder.newFolder("parent").toPath();

0 commit comments

Comments
 (0)