Skip to content

Commit 3fb96dd

Browse files
authored
Merge pull request #20574 from davidtaylorhq/follow-redirects
2 parents ccc0a7b + f61621d commit 3fb96dd

File tree

11 files changed

+22
-22
lines changed

11 files changed

+22
-22
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
"ember-router-generator": "^2.0.0",
8484
"inflection": "^2.0.1",
8585
"route-recognizer": "^0.3.4",
86-
"router_js": "^8.0.5",
86+
"router_js": "^8.0.6",
8787
"semver": "^7.5.2",
8888
"silent-error": "^1.1.1",
8989
"simple-html-tokenizer": "^0.5.11"

packages/@ember/-internals/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"ember-template-compiler": "workspace:*",
7070
"expect-type": "^0.15.0",
7171
"internal-test-helpers": "workspace:*",
72-
"router_js": "^8.0.5",
72+
"router_js": "^8.0.6",
7373
"rsvp": "^4.8.5"
7474
},
7575
"devDependencies": {

packages/@ember/application/instance.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -263,11 +263,6 @@ class ApplicationInstance extends EngineInstance {
263263
let handleTransitionReject = (error: any): unknown => {
264264
if (error.error && error.error instanceof Error) {
265265
throw error.error;
266-
} else if (error.name === 'TransitionAborted' && router._routerMicrolib.activeTransition) {
267-
return router._routerMicrolib.activeTransition.then(
268-
handleTransitionResolve,
269-
handleTransitionReject
270-
);
271266
} else if (error.name === 'TransitionAborted') {
272267
throw new Error(error.message);
273268
} else {
@@ -284,6 +279,7 @@ class ApplicationInstance extends EngineInstance {
284279
// getURL returns the set url with the rootURL stripped off
285280
return router
286281
.handleURL(location.getURL())
282+
.followRedirects()
287283
.then(handleTransitionResolve, handleTransitionReject);
288284
}
289285

packages/@ember/application/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@
3030
"ember-template-compiler": "workspace:*",
3131
"expect-type": "^0.15.0",
3232
"internal-test-helpers": "workspace:*",
33-
"router_js": "^8.0.5"
33+
"router_js": "^8.0.6"
3434
}
3535
}

packages/@ember/engine/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
"dag-map": "^2.0.2",
2828
"expect-type": "^0.15.0",
2929
"internal-test-helpers": "workspace:*",
30-
"router_js": "^8.0.5"
30+
"router_js": "^8.0.6"
3131
}
3232
}

packages/@ember/routing/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@
3737
"dag-map": "^2.0.2",
3838
"expect-type": "^0.15.0",
3939
"internal-test-helpers": "workspace:*",
40-
"router_js": "^8.0.5"
40+
"router_js": "^8.0.6"
4141
}
4242
}

packages/ember-testing/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
"backburner.js": "^2.7.0",
2828
"ember": "workspace:*",
2929
"internal-test-helpers": "workspace:*",
30-
"router_js": "^8.0.5"
30+
"router_js": "^8.0.6"
3131
}
3232
}

packages/ember/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"ember-testing": "workspace:*",
4747
"expect-type": "^0.15.0",
4848
"internal-test-helpers": "workspace:*",
49-
"router_js": "^8.0.5",
49+
"router_js": "^8.0.6",
5050
"rsvp": "^4.8.5"
5151
}
5252
}

packages/ember/tests/routing/decoupled_basic_test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,11 @@ moduleFor(
698698
// if we transition in this test we will receive failures
699699
// if the tests are run from a static file
700700
_doURLTransition() {
701-
return RSVP.resolve('');
701+
return {
702+
followRedirects() {
703+
return RSVP.resolve('');
704+
},
705+
};
702706
},
703707
});
704708

packages/internal-test-helpers/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"dag-map": "^2.0.2",
4040
"ember": "workspace:*",
4141
"ember-template-compiler": "workspace:*",
42-
"router_js": "^8.0.5",
42+
"router_js": "^8.0.6",
4343
"rsvp": "^4.8.5",
4444
"simple-html-tokenizer": "^0.5.11"
4545
}

0 commit comments

Comments
 (0)