Total time calculation seems to be incorrect

[wlupton]

I just noticed (after receiving the energy usage email reports for many weeks!) that the total time calculation seems to be incorrect. It looks like it uses six days (the number of days between the first and last) rather than seven days (the number of days in the week).

For example, this is from my latest email. Given a total usage of 70.8 kWh I'd expect 70.8 / 7 = 10.1 per day, not 11.8!

Total Use: 70.8 kWh
11.8 kWh per day

I think that that the following two lines are incorrect. I'm not sure what the cleanest fix is (I'll leave that to you unless you'd like a suggestion). Thanks!

emailreport/emailreport-module/emailreportgenerator.php

Line 70 in 0b86983

$totaltime = ($data[6][0] - $data[0][0])*0.001;

emailreport/emailreport-module/emailreportgenerator.php

Line 200 in 0b86983

$totaltime = ($use_data[6][0] - $use_data[0][0])*0.001;

[wlupton]

Ah, it looks like this was changed relatively recently, in 458987b. Perhaps the fix is just reverting 6 to 7?

Update: Well, no that won't work. I'm guessing that the earlier 7 to 6 change resulted from having reduced the number of days of data from 8 to 7. So perhaps the fix is to set the total time to be the period over which the data was collected (a week)?

[wlupton]

@TrystanLea any thoughts about this? Thanks