Skip to content

Commit ee52394

Browse files
authored
Change standalone wasm vm tests to emit a test skip when wasm engine is not present (#24631)
Change standalone wasm vm tests to emit a test skip when wasm engine is not present, rather than print a warning and then possibly fail. Fixes `test/runner core2g.test_eval_ctors_standalone` without a Wasm engine present.
1 parent 2659582 commit ee52394

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test/common.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1995,7 +1995,10 @@ def _build_and_run(self, filename, expected_output, args=None,
19951995
# TODO once standalone wasm support is more stable, apply use_all_engines
19961996
# like with js engines, but for now as we bring it up, test in all of them
19971997
if not self.wasm_engines:
1998-
logger.warning('no wasm engine was found to run the standalone part of this test')
1998+
if 'EMTEST_SKIP_WASM_ENGINE' in os.environ:
1999+
self.skipTest('no wasm engine was found to run the standalone part of this test')
2000+
else:
2001+
logger.warning('no wasm engine was found to run the standalone part of this test (Use EMTEST_SKIP_WASM_ENGINE to skip)')
19992002
engines += self.wasm_engines
20002003
if len(engines) == 0:
20012004
self.fail('No JS engine present to run this test with. Check %s and the paths therein.' % config.EM_CONFIG)

0 commit comments

Comments
 (0)