Skip to content

Commit ce34785

Browse files
authored
Disable Playwright Trace (#13801)
- As environment is fully included in trace, disabling to stop leak of any sensitive details.
1 parent 6f56cd0 commit ce34785

File tree

5 files changed

+7
-42
lines changed

5 files changed

+7
-42
lines changed

.github/workflows/extra-nightly-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
ENSO_CLOUD_COGNITO_REGION: ${{ vars.ENSO_CLOUD_COGNITO_REGION }}
130130
ENSO_CLOUD_COGNITO_USER_POOL_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_ID }}
131131
ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID }}
132-
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
132+
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
133133
ENSO_CLOUD_TEST_ACCOUNT_USERNAME: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
134134
ENSO_SNOWFLAKE_ACCOUNT: ${{ secrets.ENSO_SNOWFLAKE_ACCOUNT }}
135135
ENSO_SNOWFLAKE_DATABASE: ${{ secrets.ENSO_SNOWFLAKE_DATABASE }}
@@ -214,7 +214,7 @@ jobs:
214214
ENSO_CLOUD_COGNITO_REGION: ${{ vars.ENSO_CLOUD_COGNITO_REGION }}
215215
ENSO_CLOUD_COGNITO_USER_POOL_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_ID }}
216216
ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID }}
217-
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
217+
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
218218
ENSO_CLOUD_TEST_ACCOUNT_USERNAME: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
219219
ENSO_SNOWFLAKE_ACCOUNT: ${{ secrets.ENSO_SNOWFLAKE_ACCOUNT }}
220220
ENSO_SNOWFLAKE_DATABASE: ${{ secrets.ENSO_SNOWFLAKE_DATABASE }}
@@ -299,7 +299,7 @@ jobs:
299299
ENSO_CLOUD_COGNITO_REGION: ${{ vars.ENSO_CLOUD_COGNITO_REGION }}
300300
ENSO_CLOUD_COGNITO_USER_POOL_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_ID }}
301301
ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID: ${{ vars.ENSO_CLOUD_COGNITO_USER_POOL_WEB_CLIENT_ID }}
302-
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
302+
ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
303303
ENSO_CLOUD_TEST_ACCOUNT_USERNAME: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
304304
ENSO_LIB_S3_AWS_ACCESS_KEY_ID: ${{ secrets.ENSO_LIB_S3_AWS_ACCESS_KEY_ID }}
305305
ENSO_LIB_S3_AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}

.github/workflows/ide-packaging-optional.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -216,15 +216,8 @@ jobs:
216216
env:
217217
DEBUG: "pw:browser log:"
218218
ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
219-
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
219+
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
220220
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
221-
- if: failure()
222-
name: Upload Test Traces
223-
uses: actions/upload-artifact@v4
224-
with:
225-
compression-level: 0
226-
name: test-traces-macos-amd64
227-
path: app/ide-desktop/client/test-traces
228221
- name: Upload ide
229222
uses: actions/upload-artifact@v4
230223
with:

.github/workflows/ide-packaging.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -346,15 +346,8 @@ jobs:
346346
DEBUG: "pw:browser log:"
347347
ENSO_TEST_APP_ARGS: --no-sandbox
348348
ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
349-
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
349+
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
350350
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
351-
- if: failure()
352-
name: Upload Test Traces
353-
uses: actions/upload-artifact@v4
354-
with:
355-
compression-level: 0
356-
name: test-traces-linux-amd64
357-
path: app/ide-desktop/client/test-traces
358351
- name: Upload ide
359352
uses: actions/upload-artifact@v4
360353
with:
@@ -443,15 +436,8 @@ jobs:
443436
env:
444437
DEBUG: "pw:browser log:"
445438
ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
446-
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
439+
ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASS }}
447440
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
448-
- if: failure()
449-
name: Upload Test Traces
450-
uses: actions/upload-artifact@v4
451-
with:
452-
compression-level: 0
453-
name: test-traces-windows-amd64
454-
path: app/ide-desktop/client/test-traces
455441
- name: Upload ide
456442
uses: actions/upload-artifact@v4
457443
with:

build_tools/build/src/ci_gen.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ pub mod secret {
124124
pub const ENSO_CLOUD_COGNITO_USER_POOL_ID: &str = "ENSO_CLOUD_COGNITO_USER_POOL_ID";
125125
pub const ENSO_CLOUD_COGNITO_REGION: &str = "ENSO_CLOUD_COGNITO_REGION";
126126
pub const ENSO_CLOUD_TEST_ACCOUNT_USERNAME: &str = "ENSO_CLOUD_TEST_ACCOUNT_USERNAME";
127-
pub const ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: &str = "ENSO_CLOUD_TEST_ACCOUNT_PASSWORD";
127+
pub const ENSO_CLOUD_TEST_ACCOUNT_PASSWORD: &str = "ENSO_CLOUD_TEST_ACCOUNT_PASS";
128128

129129
// === Apple Code Signing & Notarization ===
130130
pub const APPLE_CODE_SIGNING_CERT: &str = "APPLE_CODE_SIGNING_CERT";

build_tools/build/src/ci_gen/job.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ use ide_ci::actions::workflow::definition::checkout_repo_step;
1919
use ide_ci::actions::workflow::definition::get_input_expression;
2020
use ide_ci::actions::workflow::definition::setup_wasm_pack_step;
2121
use ide_ci::actions::workflow::definition::shell;
22-
use ide_ci::actions::workflow::definition::step::Argument;
2322
use ide_ci::actions::workflow::definition::Access;
2423
use ide_ci::actions::workflow::definition::Job;
2524
use ide_ci::actions::workflow::definition::JobArchetype;
@@ -991,19 +990,6 @@ rm dist/backend/project-manager.tar"
991990
);
992991
steps.push(test_step);
993992

994-
let upload_test_traces_step = Step {
995-
r#if: Some("failure()".into()),
996-
name: Some("Upload Test Traces".into()),
997-
uses: Some("actions/upload-artifact@v4".into()),
998-
with: Some(Argument::Other(BTreeMap::from_iter([
999-
("name".into(), format!("test-traces-{}-{}", target.0, target.1).into()),
1000-
("path".into(), "app/ide-desktop/client/test-traces".into()),
1001-
("compression-level".into(), 0.into()), // The traces are in zip already.
1002-
]))),
1003-
..Default::default()
1004-
};
1005-
steps.push(upload_test_traces_step);
1006-
1007993
let upload_ide = step::upload_artifact("Upload ide")
1008994
.with_custom_argument("name", format!("ide-{}", target.0))
1009995
.with_custom_argument(

0 commit comments

Comments
 (0)