Skip to content

Commit f82dda4

Browse files
committed
update: simplify download logic
1 parent 36b24d2 commit f82dda4

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

.github/workflows/gui-checks.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,9 @@ jobs:
9292
- name: 📥 Download Enso Engine
9393
continue-on-error: true
9494
working-directory: app/project-manager-shim
95-
run: |
96-
pnpm run download-engine | tee /tmp/download-engine-output.txt
97-
EXIT_CODE=${PIPESTATUS[0]}
98-
grep "^ENSO_RUNNER_PATH=" /tmp/download-engine-output.txt >> $GITHUB_ENV
99-
exit $EXIT_CODE
95+
run: pnpm run download-engine
10096
env:
10197
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
102-
DOWNLOAD_ENSO_RUNNER: release
10398

10499
- name: 🧪 Unit Tests
105100
id: unit-tests

app/project-manager-shim/scripts/download-engine.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ rmSync(builtDistributionPath, { recursive: true, force: true })
1515

1616
// Download the engine
1717
downloadEnsoEngine(projectRoot)
18-
.then((ensoPath) => {
19-
console.log(`ENSO_RUNNER_PATH=${ensoPath}`)
18+
.then(() => {
2019
process.exit(0)
2120
})
2221
.catch((error) => {

app/project-manager-shim/src/projectService/ensoRunner.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,6 @@ export function findEnsoExecutable(workDir: string = '.'): Path | undefined {
374374
* The type of release to download is controlled by the DOWNLOAD_ENSO_RUNNER environment variable:
375375
* - If set to 'release': downloads the latest stable release
376376
* - If set to 'prerelease' or not set: downloads the latest prerelease
377-
*
378377
* @param projectRoot - The root directory of the project where the engine will be installed
379378
* @returns A promise that resolves to the path where the engine was extracted
380379
*/

0 commit comments

Comments
 (0)