`case of` recognizes Enso values as any Java interface even though `is_a` does not

[radeusgd]

I've discovered this issue when debugging test failures on #12247 PR.

A simple repro can be following:

from Standard.Base import all

polyglot java import org.enso.base.text.TextFoldingStrategy

f x = case x of
    j : TextFoldingStrategy ->
        suffix = ", but is it really? "+(j.is_a TextFoldingStrategy).to_text
        j.to_text+" is a Java value"+suffix
    other -> other.to_text+" is not a Java value"

type My_Type
    Value x

main =
    IO.println (f 42)
    IO.println (f "abc")
    IO.println (f (My_Type.Value 1))

That code prints:

42 is not a Java value
abc is not a Java value
(My_Type.Value 1) is a Java value, but is it really? False

We can see that case of treats My_Type as if it was matching the TextFoldingStrategy interface. However is_a correctly responds that it has nothing to do with it.

I think that case of matching any Enso type with any Java interface is wrong.

[radeusgd]

Interestingly, if I replace e.g. TextFoldingStrategy interface with a class - e.g. Text_Utils then the code works correctly.

[JaroslavTulach]

• probably result of By-type pattern matching #3742
• e.g. in there since the beggining
• the problem must be somewhere here
• related to automatic conversions of TruffleObject to Java interface

enso$ git diff
diff --git engine/runtime/src/main/java/org/enso/interpreter/node/controlflow/caseexpr/PolyglotSymbolTypeBranchNode.java engine/runtime/src/main/java/org/enso/interpreter/node/controlflow/caseexpr/PolyglotSymbolTypeBranchNode.java
index 25e693d119..9ef579f11e 100644
--- engine/runtime/src/main/java/org/enso/interpreter/node/controlflow/caseexpr/PolyglotSymbolTypeBranchNode.java
+++ engine/runtime/src/main/java/org/enso/interpreter/node/controlflow/caseexpr/PolyglotSymbolTypeBranchNode.java
@@ -5,8 +5,10 @@ import com.oracle.truffle.api.RootCallTarget;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.interop.InteropLibrary;
+import com.oracle.truffle.api.interop.InvalidArrayIndexException;
 import com.oracle.truffle.api.interop.UnsupportedMessageException;
 import com.oracle.truffle.api.library.CachedLibrary;
+import com.oracle.truffle.api.nodes.ExplodeLoop;
 import com.oracle.truffle.api.nodes.NodeInfo;
 import com.oracle.truffle.api.profiles.CountingConditionProfile;
 import org.enso.interpreter.node.expression.builtin.meta.IsSameObjectNode;
@@ -50,23 +52,17 @@ public abstract class PolyglotSymbolTypeBranchNode extends BranchNode {
       VirtualFrame frame,
       Object state,
       Object target,
-      @CachedLibrary(limit = "3") InteropLibrary interop) {
+      @CachedLibrary(limit = "3") InteropLibrary iop) {
     Object tpeOfTarget = typeOfNode.findTypeOrError(target);
-    boolean test = isSameObject.execute(polyglotSymbol, tpeOfTarget);
-    if (profile.profile(test)) {
-      accept(frame, state, new Object[] {target});
-    } else {
       try {
-        if (subtypeProfile.profile(
-            interop.isMetaObject(polyglotSymbol)
-                && interop.isMetaInstance(polyglotSymbol, target))) {
-          accept(frame, state, new Object[] {target});
-        }
-      } catch (UnsupportedMessageException e) {
-        Atom err = reportError(polyglotSymbol, target);
-        throw new PanicException(err, this);
+          var test = isOneOfTheParentTypes(iop, tpeOfTarget);
+          if (profile.profile(test)) {
+              accept(frame, state, new Object[]{target});
+          }
+      } catch (UnsupportedMessageException | InvalidArrayIndexException ex) {
+          var ctx = EnsoContext.get(this);
+          throw ctx.raiseAssertionPanic(this, null, ex);
       }
-    }
   }
 
   @CompilerDirectives.TruffleBoundary