Skip to content

Conversation

@junkmd
Copy link
Collaborator

@junkmd junkmd commented May 14, 2025

See #837 and #848 (comment).

@junkmd junkmd mentioned this pull request May 14, 2025
@junkmd junkmd force-pushed the cpython-gh-100926 branch from bd57f28 to baf9f0e Compare June 4, 2025 14:04
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (5c564ec) to head (1e2577a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
comtypes/test/test_comserver.py 80.00% 1 Missing ⚠️
comtypes/util.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   84.72%   84.69%   -0.03%     
==========================================
  Files         125      125              
  Lines       11566    11532      -34     
==========================================
- Hits         9799     9767      -32     
+ Misses       1767     1765       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@junkmd junkmd force-pushed the cpython-gh-100926 branch 6 times, most recently from f7a127c to 0dd80a7 Compare June 12, 2025 23:00
@junkmd junkmd force-pushed the cpython-gh-100926 branch 5 times, most recently from 878c331 to cfbfdf9 Compare June 15, 2025 00:45
@junkmd junkmd force-pushed the cpython-gh-100926 branch 5 times, most recently from 8ffec8f to 0d7925a Compare July 12, 2025 06:31
@junkmd junkmd force-pushed the cpython-gh-100926 branch 5 times, most recently from 8950024 to 9256fa0 Compare July 19, 2025 08:38
@junkmd junkmd changed the title Support the ctypes.POINTER() caching mechanism updated in Python 3.14. Support Python 3.14. Jul 21, 2025
@junkmd junkmd force-pushed the cpython-gh-100926 branch 2 times, most recently from d444361 to f3b304e Compare July 21, 2025 01:32
@junkmd
Copy link
Collaborator Author

junkmd commented Jul 21, 2025

I added version bridges to the PyCArgObject replicated in util to reflect the field definition changes in Python's PyCArgObject from 3.13 to 3.14.

See also python/cpython@8d0e07e, python/cpython#133237, python/cpython#61103, and python/cpython#136847.

@junkmd junkmd force-pushed the cpython-gh-100926 branch from f3b304e to ca93263 Compare July 26, 2025 06:37
to accommodate the changes in `ctypes` in Python 3.14, including the
deprecation of `_pointer_type_cache` and the introduction of the
`__pointer_type__` attribute protocol.
junkmd added 5 commits July 27, 2025 11:31
to accommodate the changes in `ctypes` in Python 3.14, including the
deprecation of `_pointer_type_cache` and the introduction of the
`__pointer_type__` attribute protocol.
In Python 3.14, changes to the underlying C structures in `ctypes`
require more explicit control over memory layout. This change
enforces 8-byte alignment, which correctly pads the structure
and ensures that the `value` field is accessed at the correct
offset.
This is critical for preventing memory corruption and maintaining
compatibility on both 32-bit and 64-bit systems.
@junkmd junkmd force-pushed the cpython-gh-100926 branch from ca93263 to 25c0198 Compare July 27, 2025 02:31
with:
python-version: ${{ matrix.python-version }}
architecture: ${{ matrix.architecture }}
allow-prereleases: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.14 have been released. You can remove this line.

with:
python-version: ${{ matrix.python-version }}
architecture: ${{ matrix.architecture }}
allow-prereleases: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.14 have been released. You can remove this line.

@junkmd junkmd changed the title Support Python 3.14. Support Python 3.14 and drop Python 3.8. Oct 11, 2025
@junkmd
Copy link
Collaborator Author

junkmd commented Oct 11, 2025

Due to frequent test failures, test_comserver.TestInproc_win32com.test_eval will be skipped on Python 3.14.

if sys.version_info >= (3, 14):
@unittest.skip("Fails occasionally with a memory leak on INPROC.")
def test_eval(self):
# This test sometimes leaks memory when run as an in-process server.
pass

@junkmd junkmd marked this pull request as ready for review October 11, 2025 09:01
@junkmd junkmd merged commit 2429d34 into enthought:main Oct 11, 2025
145 of 150 checks passed
@junkmd junkmd added this to the 1.4.13 milestone Oct 12, 2025
@junkmd junkmd added the enhancement New feature or request label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants