Skip to content

Commit 404bcc5

Browse files
committed
[Tests] test improvements
1 parent 9c92f91 commit 404bcc5

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

packages/enzyme-test-suite/test/ReactWrapper-spec.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1171,15 +1171,17 @@ describeWithDOM('mount', () => {
11711171
const SuspenseComponent = () => (
11721172
<Suspense fallback={<Fallback />}>
11731173
<div />
1174-
<div />
1174+
<span />
1175+
<main />
11751176
</Suspense>
11761177
);
11771178

11781179
const wrapper = mount(<SuspenseComponent />);
11791180
expect(wrapper.debug()).to.equal(`<SuspenseComponent>
11801181
<Suspense fallback={{...}}>
11811182
<div />
1182-
<div />
1183+
<span />
1184+
<main />
11831185
</Suspense>
11841186
</SuspenseComponent>`);
11851187
});

packages/enzyme-test-suite/test/_helpers/setupAdapters.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
const util = require('util');
12
const Enzyme = require('enzyme');
23
const wrap = require('mocha-wrap');
34
// eslint-disable-next-line prefer-destructuring
@@ -12,12 +13,14 @@ const origError = console.error;
1213
wrap.register(function withConsoleThrows() {
1314
return this.withOverrides(() => console, () => ({
1415
error(msg) {
15-
origError.apply(console, arguments); // eslint-disable-line prefer-rest-params
16-
throw new EvalError(msg);
16+
/* eslint prefer-rest-params: 1 */
17+
origError.apply(console, arguments);
18+
throw new EvalError(arguments.length > 1 ? util.format.apply(util, arguments) : msg);
1719
},
1820
warn(msg) {
19-
origWarn.apply(console, arguments); // eslint-disable-line prefer-rest-params
20-
throw new EvalError(msg);
21+
/* eslint prefer-rest-params: 1, prefer-spread: 1 */
22+
origWarn.apply(console, arguments);
23+
throw new EvalError(arguments.length > 1 ? util.format.apply(util, arguments) : msg);
2124
},
2225
})).extend('with console throws', {
2326
beforeEach() {

packages/enzyme-test-suite/test/shared/lifecycles/misc.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React from 'react';
22
import sinon from 'sinon-sandbox';
33
import { expect } from 'chai';
4-
import isEqual from 'lodash.isequal';
54
import PropTypes from 'prop-types';
65

76
import {
@@ -489,7 +488,10 @@ export default function describeMisc({
489488
&& properErrorMessage(error)
490489
&& rest.length === 0);
491490
expect(third).to.deep.equal(['render']);
492-
expect(fourth).to.satisfy(([name, error, info]) => name === 'componentDidCatch' && properErrorMessage(error) && isEqual(info, expectedInfo));
491+
const [name, error, info] = fourth;
492+
expect(name).to.equal('componentDidCatch');
493+
expect(error).to.satisfy(properErrorMessage);
494+
expect(info).to.deep.equal(expectedInfo);
493495

494496
expect(stateSpy.args).to.deep.equal([
495497
[{

packages/enzyme-test-suite/test/shared/methods/debug.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ export default function describeDebug({
8989
});
9090

9191
it('displays the expected display names', () => {
92+
expect(SFCMemoWithDisplayName).to.have.property('displayName');
9293
const wrapper = Wrap((
9394
<div>
9495
<SFC />

0 commit comments

Comments
 (0)