refactor: omit unnecessary reassignment

Signed-off-by: quantpoet <[email protected]>

Author: quantpoet

cmd/pics/state.go

@@ -141,7 +141,6 @@ func stateDatabaseComparison(first kv.RwDB, second kv.RwDB, number int) error {
 	if err = second.View(context.Background(), func(readTx kv.Tx) error {
 		return first.View(context.Background(), func(firstTx kv.Tx) error {
 			for bucketName := range bucketLabels {
-				bucketName := bucketName
 				if err := readTx.ForEach(bucketName, nil, func(k, v []byte) error {
 					if firstV, _ := firstTx.GetOne(bucketName, k); firstV != nil && bytes.Equal(v, firstV) {
 						// Skip the record that is the same as in the first Db

core/state/intra_block_state_test.go

@@ -275,7 +275,6 @@ func (test *snapshotTest) run(t *testing.T) bool {
 // checkEqual checks that methods of state and checkstate return the same values.
 func (test *snapshotTest) checkEqual(state, checkstate *IntraBlockState) error {
 	for _, addr := range test.addrs {
-		addr := addr // pin
 		var err error
 		checkeq := func(op string, a, b interface{}) bool {
 			if err == nil && !reflect.DeepEqual(a, b) {

core/state/rw_v3.go

@@ -150,7 +150,6 @@ func (rs *ParallelExecutionState) applyState(txTask *TxTask, domains *dbstate.Sh
 
 	emptyRemoval := txTask.Rules.IsSpuriousDragon
 	for addr, increase := range txTask.BalanceIncreaseSet {
-		increase := increase
 		addrBytes := addr.Bytes()
 		enc0, step0, err := domains.GetLatest(kv.AccountsDomain, rs.tx, addrBytes)
 		if err != nil {

core/vm/gas_table_test.go

@@ -111,8 +111,6 @@ func testTemporalTxSD(t *testing.T) (kv.TemporalRwTx, *dbstate.SharedDomains) {
 
 func TestEIP2200(t *testing.T) {
 	for i, tt := range eip2200Tests {
-		tt := tt
-		i := i
 
 		t.Run(strconv.Itoa(i), func(t *testing.T) {
 			t.Parallel()

db/downloader/util.go

@@ -197,7 +197,6 @@ func BuildTorrentFilesIfNeed(ctx context.Context, dirs datadir.Dirs, torrentFile
 	var createdAmount atomic.Int32
 
 	for _, file := range files {
-		file := file
 
 		if ignore.Contains(file) {
 			i.Add(1)

db/kv/mdbx/kv_abstract_test.go

@@ -51,7 +51,6 @@ func TestSequence(t *testing.T) {
 	ctx := context.Background()
 
 	for _, db := range writeDBs {
-		db := db
 		tx, err := db.BeginRw(ctx)
 		require.NoError(t, err)
 		defer tx.Rollback()
@@ -114,7 +113,6 @@ func TestManagedTx(t *testing.T) {
 	ctx := context.Background()
 
 	for _, db := range writeDBs {
-		db := db
 		tx, err := db.BeginRw(ctx)
 		require.NoError(t, err)
 		defer tx.Rollback()
@@ -142,7 +140,6 @@ func TestManagedTx(t *testing.T) {
 	}
 
 	for _, db := range readDBs {
-		db := db
 		msg := fmt.Sprintf("%T", db)
 		switch db.(type) {
 		case *remotedb.DB:

db/snapshotsync/freezeblocks/block_reader.go

@@ -1241,7 +1241,6 @@ func (r *BlockReader) IterateFrozenBodies(f func(blockNum, baseTxNum, txCount ui
 	view := r.sn.View()
 	defer view.Close()
 	for _, sn := range view.Bodies() {
-		sn := sn
 		defer sn.Src().MadvSequential().DisableReadAhead()
 
 		var buf []byte

db/state/aggregator.go

@@ -397,15 +397,13 @@ func (a *Aggregator) Close() {
 func (a *Aggregator) closeDirtyFiles() {
 	wg := &sync.WaitGroup{}
 	for _, d := range a.d {
-		d := d
 		wg.Add(1)
 		go func() {
 			defer wg.Done()
 			d.Close()
 		}()
 	}
 	for _, ii := range a.iis {
-		ii := ii
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

db/state/dirty_files.go

@@ -498,7 +498,6 @@ func (ii *InvertedIndex) openDirtyFiles() error {
 	invalidFileItemsLock := sync.Mutex{}
 	ii.dirtyFiles.Walk(func(items []*FilesItem) bool {
 		for _, item := range items {
-			item := item
 			fromStep, toStep := kv.Step(item.startTxNum/ii.stepSize), kv.Step(item.endTxNum/ii.stepSize)
 			if item.decompressor == nil {
 				fPathPattern := ii.efFilePathMask(fromStep, toStep)

db/state/history.go

@@ -349,7 +349,6 @@ func (h *History) buildVI(ctx context.Context, historyIdxPath string, hist, efHi
 func (h *History) BuildMissedAccessors(ctx context.Context, g *errgroup.Group, ps *background.ProgressSet, historyFiles *MissedAccessorHistoryFiles) {
 	h.InvertedIndex.BuildMissedAccessors(ctx, g, ps, historyFiles.ii)
 	for _, item := range historyFiles.missedMapAccessors() {
-		item := item
 		g.Go(func() error {
 			return h.buildVi(ctx, item, ps)
 		})