refactor: omit unnecessary reassignment #17147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Sep 24, 2025
|
Thansk for your reply. I found the error messages for two failed CI: Run docker/login-action@v3
Error: Username and password requiredDo I need to take any action? |
|
merge main |
Signed-off-by: quantpoet <[email protected]>
Updated to the latest code. Please review again when you have time. Thanks! @AskAlexSharov |
taratorio
pushed a commit
that referenced
this pull request
Oct 23, 2025
Inspired by PR #17147, and replaced additional cases as well. Signed-off-by: spuradage <[email protected]>
taratorio
pushed a commit
that referenced
this pull request
Oct 26, 2025
Inspired by #17147 and replace all. The new version of Go has been optimized, and variables do not need to be reassigned. For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore Signed-off-by: pennylees <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of Go has been optimized, and variables do not need to be reassigned.
For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore