Skip to content

Conversation

@ceh
Copy link
Contributor

@ceh ceh commented Apr 27, 2023

Add an implementation for Elasticsearch KNN search. Fixes #298.

What do you think @erikbern, @alexklibisz?

@ceh
Copy link
Contributor Author

ceh commented Apr 27, 2023

Sample run for dataset fashion-mnist-784-euclidean on my local machine (M1 Pro):

fashion-mnist-784-euclidean

Definitions file
float:
  euclidean:
    elasticsearch:
      docker-tag: ann-benchmarks-elasticsearch
      module: ann_benchmarks.algorithms.elasticsearch
      constructor: ElasticsearchKNN
      base-args: ["@metric", "@dimension"]
      run-groups:
        m-16-ef-100:
          arg-groups:
            - {"m": 16,  "ef_construction": 100} # index_options
          query-args: [[10, 20, 30, 40, 50]] # num_candidates
    opensearchknn:
      docker-tag: ann-benchmarks-opensearchknn
      module: ann_benchmarks.algorithms.opensearchknn
      constructor: OpenSearchKNN
      base-args: ["@metric", "@dimension"]
      run-groups:
        M-16:
          arg-groups:
            - {"M": 16,  "efConstruction": 512}
          query-args: [[10, 20, 30, 40, 50]]

@erikbern
Copy link
Owner

want me to merge this right now? i can re-run elasticsearch for the benchmarks (#399)

@alexklibisz
Copy link
Contributor

LGTM, from a very quick skim

@erikbern erikbern merged commit c5d4bc3 into erikbern:main Apr 27, 2023
@ceh ceh deleted the elasticsearch branch April 28, 2023 06:20
@ceh
Copy link
Contributor Author

ceh commented Apr 28, 2023

want me to merge this right now? i can re-run elasticsearch for the benchmarks (#399)

Nice! Fine to merge! Was thinking about adding a couple of run groups, but takes time to evaluate

@erikbern
Copy link
Owner

i'll probably re-run the benchmarks in the next few weeks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate Elasticsearch approximate kNN API

3 participants