`embuild` shouldn't require `git` or `.git` to exist in order to build the project

[svelterust]

When trying following in NixOS, it fails because this crate expects .git to exist for $ESP_IDF: https://github.com/knarkzel/hello-esp32c3

hello-esp32c3 via nix-shell-env ❯ cargo build
   Compiling esp-idf-sys v0.33.2
The following warnings were emitted during compilation:

warning: Configuring first supported MCU 'esp32c3' derived from the build target 'riscv32imc-esp-espidf' supporting MCUs [esp32c3, esp32c2, esp32h2, esp32c5]; explicitly specify an MCU to resolve this ambiguity

error: failed to run custom build command for `esp-idf-sys v0.33.2`

Caused by:
  process didn't exit successfully: `/home/odd/source/hello-esp32c3/target/debug/build/esp-idf-sys-c7e3a3706a45d51d/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=ESP_IDF_TOOLS_INSTALL_DIR
  cargo:rerun-if-env-changed=ESP_IDF_SDKCONFIG
  cargo:rerun-if-env-changed=ESP_IDF_SDKCONFIG_DEFAULTS
  cargo:rerun-if-env-changed=MCU
  cargo:rerun-if-env-changed=ESP_IDF_SYS_ROOT_CRATE
  cargo:rerun-if-env-changed=ESP_IDF_VERSION
  cargo:rerun-if-env-changed=ESP_IDF_REPOSITORY
  cargo:rerun-if-env-changed=ESP_IDF_CMAKE_GENERATOR
  cargo:rerun-if-env-changed=IDF_PATH
  cargo:rerun-if-env-changed=EXTRA-COMPONENTS
  cargo:rerun-if-env-changed=ESP_IDF_COMPONENTS
  cargo:warning=Configuring first supported MCU 'esp32c3' derived from the build target 'riscv32imc-esp-espidf' supporting MCUs [esp32c3, esp32c2, esp32h2, esp32c5]; explicitly specify an MCU to resolve this ambiguity

  --- stderr
  Build configuration: BuildConfig {
      esp_idf_tools_install_dir: None,
      esp_idf_sdkconfig: None,
      esp_idf_sdkconfig_defaults: None,
      mcu: None,
      native: NativeConfig {
          esp_idf_version: Some(
              Tag(
                  "v5.1.1",
              ),
          ),
          esp_idf_repository: None,
          esp_idf_cmake_generator: None,
          idf_path: Some(
              "/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1",
          ),
          extra_components: [],
          esp_idf_components: None,
      },
      esp_idf_sys_root_crate: None,
  }
  fatal: not a git repository (or any of the parent directories): .git
  fatal: not a git repository (or any of the parent directories): .git
  Error: '/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1' is not a git respository

  Caused by:
      0: command 'cd "/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1" && LANGUAGE="" LC_ALL="C.UTF-8" "git" "rev-parse" "--show-toplevel"' exited with non-zero status code 128
      1: fatal: not a git repository (or any of the parent directories): .git

[ivmarkov]

Here's a pull request that was already reviewed and requires just a little love from somebody to get merged. (As in cargo fmt.) I guess the contributor lost interest as she is not replying.

If you would like to own it, we can have this issue fixed.

What I would suggest is to clone / fork embuild with the above PR applied and patch your build to use your forked version of embuild. Do the same for esp-idf-sys (see my comment below) and then try to build this combo for *nix. If it works, you can resubmit the PR with cargo fmt applied.

[ivmarkov]

And the corresponding PR to esp-idf-sys that I can merge once the above PR is merged.

[svelterust]

Awesome, I'll give it a shot

[ivmarkov]

@knarkzel Sorry - I've deleted your post. You know it could be anything as to why the previous contributor has not reacted.

Let's concentrate on owning and fixing the PR instead. :)

[svelterust]

Ait, so I tried out these patches:

[patch.crates-io]
esp-idf-sys = { git = "https://github.com/haileys/esp-idf-sys.git", rev = "211af868958ed5f5ceb2b7945a56bb131fd6ec11" }
embuild = { git = "https://github.com/haileys/embuild.git", rev = "5292871f5b3a0a78f398f80e8c159f47afb1df87" }

Output of cargo tree: https://pastebin.com/raw/f1rpDEwp

Still get the same error, am I missing something obvious?

  --- stderr
  Build configuration: BuildConfig {
      esp_idf_tools_install_dir: None,
      esp_idf_sdkconfig: None,
      esp_idf_sdkconfig_defaults: None,
      mcu: None,
      native: NativeConfig {
          esp_idf_version: Some(
              Tag(
                  "v5.1.1",
              ),
          ),
          esp_idf_repository: None,
          esp_idf_cmake_generator: None,
          idf_path: Some(
              "/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1",
          ),
          extra_components: [],
          esp_idf_components: None,
          esp_idf_component_manager: None,
      },
      esp_idf_sys_root_crate: None,
  }
  fatal: not a git repository (or any of the parent directories): .git
  Using activated esp-idf v5.1.0 environment at '/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1'
  thread 'main' panicked at /home/odd/.cargo/git/checkouts/esp-idf-sys-47955e843e87bb38/211af86/build/native/cargo_driver.rs:261:13:
  tree must always be Git variant if is_managed_espidf is true
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Is it this is_managed_espidf that must be set?

[svelterust]

haileys/esp-idf-sys@c4b8098#diff-34a4c2047b858b330b2ca645dea0213b084e260f61c03c5288b65e2a395d3e9cR188-R189

[svelterust]

Need to run this custom path instead, what's the env variable for that?

[ivmarkov]

IDF_PATH

[svelterust]

hello-esp32c3 via nix-shell-env ❯ echo $IDF_PATH
/nix/store/bmckqqb26qy16agaql75m5w1bwi4kp51-esp-idf-v5.1

[svelterust]

It still thinks it's managed despite having this.

[ivmarkov]

Well you might have to dig deeper. As in setting export RUST_BACKTRACE=1 and then re-running the build. This would give you an idea where exactly in the esp-idf-sys Rust build code fails, and you can look what is going on there.

[svelterust]

https://pastebin.com/raw/Db6597GS

[svelterust]

Hmm lets see...

  tree must always be Git variant if is_managed_espidf is true
  stack backtrace:
     0: rust_begin_unwind
               at /rustc/97c81e1b537088f1881c8894ee8579812ed9b6d1/library/std/sr     1: core::panicking::panic_fmt
               at /rustc/97c81e1b537088f1881c8894ee8579812ed9b6d1/library/core/s     2: build_script_build::native::cargo_driver::build
               at ./build/native/cargo_driver.rs:261:13
     3: build_script_build::native::build
               at ./build/native.rs:17:9
     4: build_script_build::main
               at ./build/build.rs:52:24
     5: core::ops::function::FnOnce::call_once
               at /rustc/97c81e1b537088f1881c8894ee8579812ed9b6d1/library/core/s

[svelterust]

I must be failing to patch something because the PR looks good