Skip to content

Commit c3badbb

Browse files
authored
workflows/release-binaries.yml: Only dump the wix logs on failure (llvm#218810)
There is currently a bug in the path on ARM64 Windows, so this step always fails. Running it after a successful build doesn't make much sense anyway since since we don't need to see the logs for a good build. Also, we risk having it fail the whole job even after a successful build (like what is currently happening on ARM64 Windows), so that's another reason only to run this when the bulid fails.
1 parent a9797b1 commit c3badbb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/release-binaries.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ jobs:
316316
echo "windows-installer-filename=$(Split-Path -Path $installer -Leaf)" >> $env:GITHUB_OUTPUT
317317
318318
- name: Dump Wix logs
319-
if: runner.os == 'Windows' && always()
319+
if: runner.os == 'Windows' && failure()
320320
env:
321321
LLVM_VERSION: ${{ needs.prepare.outputs.release-version }}
322322
BUILD_DIR_SUFFIX: ${{ case(runner.arch == 'ARM64', 'arm64', 'amd64') }}

0 commit comments

Comments
 (0)