Skip to content

Fix contradictory ToC card width caps - #19032

Merged
pettinarip merged 1 commit into
devfrom
fix/toc-card-width
Aug 21, 2026
Merged

Fix contradictory ToC card width caps#19032
pettinarip merged 1 commit into
devfrom
fix/toc-card-width

Conversation

@myelinated-wackerow

Copy link
Copy Markdown
Collaborator

Summary

The card variant of TableOfContents set min-w-80 and max-w-72 on the same element, a 320px floor above a 288px ceiling — min wins in CSS, so the max was dead and the card always rendered at 320px. Both are replaced with w-80 on root, where the file's own comment says width caps belong. Rendered width is unchanged at 320px, verified at 1000/1200/1536px.

The card variant set `min-w-80 max-w-72` on the same element, so the 288px max never applied and the card always rendered at the 320px min. Replaces both with `w-80` on `root`, where the file's own note says width caps belong. Rendered width is unchanged at 320px.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit dd31fdb
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6a7a5fcf4385cb00085540cb
😎 Deploy Preview https://deploy-preview-19032.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 56 (🔴 down 3 from production)
Accessibility: 95 (no change from production)
Best Practices: 100 (🟢 up 1 from production)
SEO: 98 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

🔎 First-pass review — ✅ Looks mergeable

One-line CSS correctness fix on TableOfContents. The card variant carried min-w-80 max-w-72 on the container slot — a 320px floor above a 288px ceiling, so min-width won and max-w-72 was dead code; the card always rendered at 320px. The fix removes both and moves w-80 onto root, which matches the slot's own width-caps note (line 18) and the docs variant that also puts width caps on root. Rendered width stays 320px (container fills the now-w-80 root), consistent with the multi-breakpoint verification in the description.

Analysis
  • Lane: code (src/components/TableOfContents/index.tsx)
  • Checked: the removed/added Tailwind classes against the CSS min/max precedence claim, placement against the existing root width-caps comment, and consistency with the docs variant. tv (not cva), no unused vars, no raw Intl.*, no chain names — all clean.
  • Non-blocking: none. CI may still be running.

Generated by PR Reviewer (team) for #19032 · 63.9 AIC · ⌖ 10.1 AIC · ⊞ 5.2K ·

@pettinarip
pettinarip merged commit 2bf8cf9 into dev Aug 21, 2026
22 checks passed
@pettinarip
pettinarip deleted the fix/toc-card-width branch August 21, 2026 14:30
@pettinarip pettinarip mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants