Skip to content

Commit a93c30f

Browse files
committed
[scripts] Split jdk variant from version
1 parent 8b09ce6 commit a93c30f

File tree

2 files changed

+22
-25
lines changed

2 files changed

+22
-25
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ sudo docker run --rm -it -v $BUILD_DIRECTORY:/build ev3dev-lang-java:jdk-build
3333
```
3434
Please change the `$BUILD_DIRECTORY` to a valid path.
3535

36-
5. Select the OpenJDK version you want to cross-compile (select only one):
36+
5. Select the OpenJDK version and VM you want to cross-compile (select only one for each variable):
3737
```
38-
export JDKVER=9 # OpenJDK 9 with ARM32 JIT
39-
export JDKVER=9zero # OpenJDK 9 with Zero interpreter
40-
export JDKVER=10 # OpenJDK 10 with ARM32 JIT
41-
export JDKVER=10zero # OpenJDK 10 with Zero interpreter
38+
export JDKVER=9 # OpenJDK 9
39+
export JDKVER=10 # OpenJDK 10
40+
export JDKVM=zero # Use Zero interpreter
41+
export JDKVM=client # Use ARM32 JIT
4242
```
4343
6. Before we can start the build process, Boot JDK must be downloaded:
4444
```
@@ -67,9 +67,9 @@ sudo docker build -t ev3dev-lang-java:jdk-autobuild -f scripts/Dockerfile.autoru
6767
4. Run the newly prepared container. You have to mount a host directory to the the `/build` directory in the container,
6868
otherwise the build would get discarded. The final build needs at least 6.5 GB of free space (in the build directory).
6969
```
70-
sudo docker run --rm -it -v $BUILD_DIRECTORY:/build -e JDKVER='X' ev3dev-lang-java:jdk-autobuild
70+
sudo docker run --rm -it -v $BUILD_DIRECTORY:/build -e JDKVER='X' -e JDKVM='Y' ev3dev-lang-java:jdk-autobuild
7171
```
72-
`X` can be one of `9`, `9zero`, `10` and `10zero`. Please change the `$BUILD_DIRECTORY` to a valid path.
72+
`X` can be one of `9` and `10`. `Y` can be one of `zero` and `client`, see above. Please change the `$BUILD_DIRECTORY` to a valid path.
7373

7474
5. If the build was successful, JDK packages were created in `$BUILD_DIRECTORY/jri-ev3.tar.gz`, `$BUILD_DIRECTORY/jdk-ev3.tar.gz` and `$BUILD_DIRECTORY/jmods.tar.gz`.
7575

scripts/config.sh

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -47,33 +47,19 @@ JDKDIR="/build/jdk"
4747
#HOSTJDK_URL="https://download.java.net/java/GA/jdk9/9.0.4/binaries/openjdk-9.0.4_linux-x64_bin.tar.gz"
4848

4949
# OpenJDK 9
50-
if [ "$JDKVER" == "9" ] || [ "$JDKVER" == "9zero" ]; then
50+
if [ "$JDKVER" == "9" ]; then
5151
JAVA_REPO="http://hg.openjdk.java.net/jdk-updates/jdk9u/"
5252
PATCHVER="jdk9"
5353
AUTOGEN_PATH="./common/autoconf/autogen.sh"
54-
if [ "$JDKVER" == "9zero" ]; then
55-
HOTSPOT_VARIANT=zero
56-
IMAGEDIR="/build/jdk/build/linux-arm-normal-zero-release/images"
57-
else
58-
HOTSPOT_VARIANT=client
59-
IMAGEDIR="/build/jdk/build/linux-arm-normal-client-release/images"
60-
fi
6154
HOSTJDK="$BUILDDIR/jdk-9.0.4"
6255
HOSTJDK_FILE="$BUILDDIR/openjdk-9.0.4_linux-x64_bin.tar.gz"
6356
HOSTJDK_URL="https://download.java.net/java/GA/jdk9/9.0.4/binaries/openjdk-9.0.4_linux-x64_bin.tar.gz"
6457

6558
# OpenJDK 10
66-
elif [ "$JDKVER" == "10" ] || [ "$JDKVER" == "10zero" ]; then
59+
elif [ "$JDKVER" == "10" ]; then
6760
JAVA_REPO="http://hg.openjdk.java.net/jdk-updates/jdk10u/"
6861
PATCHVER="jdk10"
6962
AUTOGEN_PATH="./make/autoconf/autogen.sh"
70-
if [ "$JDKVER" == "10zero" ]; then
71-
HOTSPOT_VARIANT=zero
72-
IMAGEDIR="/build/jdk/build/linux-arm-normal-zero-release/images"
73-
else
74-
HOTSPOT_VARIANT=client
75-
IMAGEDIR="/build/jdk/build/linux-arm-normal-client-release/images"
76-
fi
7763
HOSTJDK="$BUILDDIR/jdk-10"
7864
HOSTJDK_FILE="$BUILDDIR/openjdk-10_linux-x64_bin.tar.gz"
7965
HOSTJDK_URL="https://download.java.net/java/GA/jdk10/10/binaries/openjdk-10_linux-x64_bin.tar.gz"
@@ -83,8 +69,19 @@ else
8369
echo "Error! Please specify JDK version to compile via the JDKVER environment variable." >&2
8470
echo "Acceptable values:" >&2
8571
echo "JDKVER=9" >&2
86-
echo "JDKVER=9zero" >&2
8772
echo "JDKVER=10" >&2
88-
echo "JDKVER=10zero" >&2
8973
exit 1
9074
fi
75+
76+
77+
# invalid or unset VM
78+
if [ "$JDKVM" != "zero" ] && [ "$JDKVM" != "client" ]; then
79+
echo "Error! Please specify JDK VM to compile via the JDKVM environment variable." >&2
80+
echo "Acceptable values:" >&2
81+
echo "JDKVM=client" >&2
82+
echo "JDKVM=zero" >&2
83+
exit 1
84+
fi
85+
86+
HOTSPOT_VARIANT="$JDKVM"
87+
IMAGEDIR="/build/jdk/build/linux-arm-normal-${JDKVM}-release/images"

0 commit comments

Comments
 (0)