Merge pull request #10 from bitExpert-forks/fix-update-delete-many

Fix updateMany() and deleteMay() of InMemoryDocumentStore

Author: Alexander Miertsch

src/InMemoryDocumentStore.php

@@ -215,10 +215,14 @@ public function updateDoc(string $collectionName, string $docId, array $docOrSub
      */
     public function updateMany(string $collectionName, Filter $filter, array $set): void
     {
-        $docs = $this->filterDocs($collectionName, $filter);
+        $this->assertHasCollection($collectionName);
+
+        $docs = $this->inMemoryConnection['documents'][$collectionName];
 
         foreach ($docs as $docId => $doc) {
-            $this->updateDoc($collectionName, $docId, $set);
+            if ($filter->match($doc, (string)$docId)) {
+                $this->updateDoc($collectionName, (string)$docId, $set);
+            }
         }
     }
 
@@ -258,10 +262,14 @@ public function deleteDoc(string $collectionName, string $docId): void
      */
     public function deleteMany(string $collectionName, Filter $filter): void
     {
-        $docs = $this->filterDocs($collectionName, $filter);
+        $this->assertHasCollection($collectionName);
+
+        $docs = $this->inMemoryConnection['documents'][$collectionName];
 
         foreach ($docs as $docId => $doc) {
-            $this->deleteDoc($collectionName, $docId);
+            if ($filter->match($doc, (string)$docId)) {
+                $this->deleteDoc($collectionName, (string)$docId);
+            }
         }
     }
 

tests/InMemoryDocumentStoreTest.php

@@ -4,6 +4,7 @@
 namespace EventEngineTest\DocumentStore;
 
 use EventEngine\DocumentStore\FieldIndex;
+use EventEngine\DocumentStore\Filter\AnyFilter;
 use EventEngine\DocumentStore\Filter\EqFilter;
 use EventEngine\DocumentStore\InMemoryDocumentStore;
 use EventEngine\DocumentStore\MultiFieldIndex;
@@ -200,4 +201,50 @@ public function it_does_not_block_adding_a_unique_multi_field_index_if_no_confli
         $this->store->addCollectionIndex('test', $uniqueIndex);
         $this->assertTrue($this->store->hasCollectionIndex('test', 'test_idx'));
     }
+
+    /**
+     * @test
+     */
+    public function it_updates_many()
+    {
+        $this->store->addCollection('test');
+
+        $this->store->addDoc('test', '1', ['some' => ['prop' => 'foo', 'other' => ['prop' => 'bat']]]);
+        $this->store->addDoc('test', '2', ['some' => ['prop' => 'bar', 'other' => ['prop' => 'bat']]]);
+        $this->store->addDoc('test', '3', ['some' => ['prop' => 'bar']]);
+
+        $this->store->updateMany(
+            'test',
+            new EqFilter('some.other.prop', 'bat'),
+            ['some' => ['prop' => 'fuzz']]
+        );
+
+        $filteredDocs = iterator_to_array($this->store->filterDocs('test', new EqFilter('some.prop', 'fuzz')));
+
+        $this->assertCount(2, $filteredDocs);
+        $this->assertEquals('fuzz', $filteredDocs[0]['some']['prop']);
+        $this->assertEquals('fuzz', $filteredDocs[1]['some']['prop']);
+    }
+
+    /**
+     * @test
+     */
+    public function it_deletes_many()
+    {
+        $this->store->addCollection('test');
+
+        $this->store->addDoc('test', '1', ['some' => ['prop' => 'foo', 'other' => ['prop' => 'bat']]]);
+        $this->store->addDoc('test', '2', ['some' => ['prop' => 'bar', 'other' => ['prop' => 'bat']]]);
+        $this->store->addDoc('test', '3', ['some' => ['prop' => 'bar']]);
+
+        $this->store->deleteMany(
+            'test',
+            new EqFilter('some.other.prop', 'bat')
+        );
+
+        $filteredDocs = iterator_to_array($this->store->filterDocs('test', new AnyFilter()));
+        
+        $this->assertCount(1, $filteredDocs);
+        $this->assertEquals(['some' => ['prop' => 'bar']], $filteredDocs[0]);
+    }
 }